search

MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
38 stars 9 forks source link

Error+Spec OR Warning+Best Practice: Departure times should increase #125

Open e-lo opened 2 years ago

e-lo commented 2 years ago

Spec violations should be errors, but the below best practice is an error and not in the spec. Options:

  1. Add this requirement to the GTFS RT Spec definition and remove from GTFS Best Practices.
  2. Change the error to a warning in the validator and make the text consistent between the Best Practices and the error.

Relevant Best Practice text:

StopTimeUpdate.departure: Departure times between sequential stops should increase - they should not be the same or decrease

Relevant Rule

E022 - Sequential stop_time_update times are not increasing stop_time_update arrival/departure times between sequential stops should always increase - they should never be the same or decrease.

References: Stop Time Updates description stop_time_update reference

barbeau commented 2 years ago

I believe this is covered in: https://github.com/MobilityData/gtfs-realtime-validator/blob/master/RULES.md#e022---sequential-stop_time_update-times-are-not-increasing

e-lo commented 2 years ago

Thx @barbeau : I updated the issue to reflect the inconsistence in spec vs best practice treatment for this check.