search

MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
38 stars 9 forks source link

E041: Wording Consistency with Best Practices #137

Closed e-lo closed 2 years ago

e-lo commented 2 years ago

Need Consistency between Best Practices text and the existing warning: E041. I think the meaning is the same, we should just make the text identical (or at least closer!)

Relevant Best Practice text:

All TripUpdates should include at least one stop_time_update with a predicted arrival or departure time in the future. If all stop_time_updates for a trip reference past arrival and departure times, consumers should assume that no real-time data is available for the trip.

E041 Text

Unless a trip's schedule_relationship is CANCELED, a trip must have at least one stop_time_update

barbeau commented 2 years ago

IIRC, the above referenced best practice is different from E041 because of the text regarding the times:

...with a predicted arrival or departure time in the future. If all stop_time_updates for a trip reference past arrival and departure times, consumers should assume that no real-time data is available for the trip.

This issue discusses some of the subtleties that need to be considered for this to become a (new?) rule: https://github.com/MobilityData/gtfs-realtime-validator/issues/67

e-lo commented 2 years ago

Closed as duplicate after moving relevant text to #37 and labeling it with GTFS-RT Best Practices.