MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
41 stars 10 forks source link

Add "About" menu in webapp #52

Open isabelle-dr opened 2 years ago

isabelle-dr commented 2 years ago

Issue by barbeau Oct 25, 2017 Originally opened as https://github.com/CUTR-at-USF/gtfs-realtime-validator/issues/299


Summary:

In the upper-right corner of the landing page, we have "About" menu option that currently doesn't do anything when clicked. 31552908-c6eed9e4-b006-11e7-868c-79a15ed2efec (1) We need to fill this in. For "About", I'd like it to be a small drop-down that includes the Maven version number of the build and the Git commit ID for the head commit on which it was built.

Steps to reproduce:

Go to landing website page

Expected behavior:

Be able to find out more in "About" menu item by clicking on it

Observed behavior:

Nothing happens when you click on it

isabelle-dr commented 2 years ago

Comment by Suryakandukoori Nov 1, 2017


@barbeau do you want the Maven version number of the build and the Git commit ID for the head commit fetched 'dynamically' for each build? or manually fetch from any particular location?

isabelle-dr commented 2 years ago

Comment by barbeau Nov 1, 2017


@Suryakandukoori I'd prefer to have it fetched dynamically on each build (e.g., for Maven pull it from pom.xml and the tag) so we don't have to manually change it.

I'm going to be committing the changes for #295 today, so you might want to hold off working on this until I finish that as the file locations will change and you'd be pulling from the submodules instead of one pom.xml.

So, after #295 is merged, the project will have two submodules:

isabelle-dr commented 2 years ago

Comment by barbeau Nov 1, 2017


@Suryakandukoori Ok, I just merged #295, so you can continue doing this without any conflicts now.

barbeau commented 2 years ago

There is initial work towards this in PR https://github.com/MobilityData/gtfs-realtime-validator/pull/84.