search

MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
41 stars 10 forks source link

StopTimeUpdate.ScheduleRelationship must not be SCHEDULED or SKIPPED for frequency type 0 trips #63

Open isabelle-dr opened 2 years ago

isabelle-dr commented 2 years ago

Issue by barbeau Sep 10, 2018 Originally opened as https://github.com/CUTR-at-USF/gtfs-realtime-validator/issues/334

Summary:

For trips defined in frequencies.txt with exact_times=0, TripUpdates feeds should not have stop_time_updates with a schedule_relationship of SCHEDULED or SKIPPPED - these are only relevant for schedule-based transit (trips not defined in frequencies.txt or in frequencies.txt but with exact_times=1).

So, the following feed should not be valid:

entity {
  id: "1121"
  trip_update {
    trip {
      trip_id: "5"
      start_time: "19:29:28"
      start_date: "20180910"
      schedule_relationship: UNSCHEDULED
      route_id: "C"
    }
    stop_time_update {
      stop_sequence: 1
      arrival {
        time: 1536609516
      }
      stop_id: "421"
      schedule_relationship: SCHEDULED
    }
    stop_time_update {
      stop_sequence: 2
      arrival {
        time: 1536609552
      }
      stop_id: "425"
      schedule_relationship: SCHEDULED
    }

Related - I'm proposing adding an StopTimeUpdate.ScheduleRelationship UNSCHEDULED enumeration value in GTFS-realtime spec here: google/transit#102

EDIT - Actually, considering that SCHEDULED is the default value, it shouldn't really be empty either, although until the above issue is clarified in GTFS-rt, I suppose empty is the best option.

Steps to reproduce:

Run TransitClock on USF Bull Runner data: https://github.com/CUTR-at-USF/bullrunner-gtfs-realtime-generator

Expected behavior:

Flag stop_time_update with the values of SCHEDULED or SKIPPPED as an error for trips that are defined in frequencies.txt with exact_times=0 (or empty)

Observed behavior:

Validator does not flag stop_time_updates with the values of SCHEDULED or SKIPPPED as an error for trips that are defined in frequencies.txt with exact_times=0 (or empty)

Platform:

N/A

cc @scrudden

isabelle-dr commented 2 years ago

Comment by scrudden Sep 16, 2018

I will go ahead with this with the check being that the value is not set to SCHEDULED. We can change this later to check for UNSCHEDULED if the change to the specification is agreed.

On this branch.