search

MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
41 stars 10 forks source link

Change E016 error to warning for ADDED trips #79

Open isabelle-dr opened 2 years ago

isabelle-dr commented 2 years ago

Issue by barbeau Sept 11, 2020 Originally opened as https://github.com/CUTR-at-USF/gtfs-realtime-validator/issues/384

Summary:

We currently have E016 for ADDED trips: https://github.com/CUTR-at-USF/gtfs-realtime-validator/blob/master/RULES.md#E016

ADDED has recently been marked as "unspecified" in GTFS-realtime, which means that the exact behavior isn't defined: google/transit#230

We should probably remove this error, as some producers could consider this case valid, and instead have a warning that ADDED trips are unspecified and behavior of consumers isn't consistent.

Steps to reproduce:

Run the validator

Expected behavior:

Don't throw errors on unspecified behavior

Observed behavior:

ADDED is now unspecified in GTFS-RT, but we throw errors on it based on our past assumption of how it works (which, it turns out, others disagree with - google/transit#230).

barbeau commented 2 years ago

As mentioned in https://github.com/MobilityData/gtfs-realtime-validator/issues/122, the current Best Practice text is:

TripDescriptor.schedule_relationship: The behavior of ADDED trips are unspecified and the use of this enumeration is not recommended.