The validation of fast travel between consecutive stops not happening

[LuisDiezLaso]

Bug report

I´m checking feeds that are supposed to throw the warning "Too fast travel between consecutive stops"(the travel speed between some stops is over 1000 km/h in the report generated by the old feed validator).

Describe the bug Not throwing "too fast travel between consecutive stops" warning when it should be.

How we reproduce the bug Tested with the latest jar produced of the master branch Steps to reproduce the behaviour:

1. Execute the jar for this feed: Gtfs-20220525-0647-.zip

Expected behaviour As produced in this report from the old validator, there should be warnings of the type "too fast travel": transitfeed-validation-results.zip

Observed behaviour There is 0 warnings of that type (this is the report that i get when executing the jar): report.zip

Environment versions

• validator version: latest jar produced of the master branch
• Java version: java 11.0.15 2022-04-19 LTS
• OS versions: Windows 10

[maximearmstrong]

Thank you for reporting this bug @LuisDiezLaso!

Currently, this is "normal" behavior - we don't run any validation rules involving multiple files if at least one file is unparsable. In the example you provided, agency.txt is unparsable, so the rule throwing the fast_travel_between_consecutive_stops notice is not checked.

We are aware that this is not sustainable in the long run, so we are planing on modifying the behavior so that it will only skip a validation rule if one of the files required to check it is unparsable.

Let's keep this issue open, which will be fixed with the implementation of the new behavior. cc @isabelle-dr

[isabelle-dr]

@davidgamez this might be the same problem as the one you found in #1308

[davidgamez]

@isabelle-dr that's correct. After a quick look at the dataset, the agency_url is invalid. This cascaded in the Multi-file validators not triggered. I fixed it locally and I was able to get the expected Too fast travel between consecutive stops notice.

Before the agency URL was fixed.

After the agency URL was fixed.

[isabelle-dr]

Closing, this issue is replaced by https://github.com/MobilityData/gtfs-validator/issues/1484