feat: used the standard date time formatter

MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.

https://gtfs-validator.mobilitydata.org/

Apache License 2.0

266 stars 100 forks source link

feat: used the standard date time formatter #1691

Closed qcdyx closed 4 months ago

qcdyx commented 4 months ago

Summary: Closes #1652 report.json

Expected behavior:

Please see the validatedAt string on the screenshot and json report.

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[ ] Add or update any needed documentation to the repo
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

davidgamez commented 4 months ago

Can we remove the milliseconds and the name of the timezone? Example: 2024-01-15T24:14:45+05:00

qcdyx commented 4 months ago

report.json Voila @davidgamez

github-actions[bot] commented 4 months ago

✅ Rule acceptance tests passed. New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1520 sources (~0 %) are corrupted. Commit: d8d6966c462f4dd8811acf21dee57c97dcfc8364 Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

qcdyx commented 4 months ago

Regarding when --date is passed in the validator question @davidgamez, I tried java -Xmx1G -jar ./cli/build/libs/gtfs-validator-4.2.1-SNAPSHOT-cli.jar -d 2023-01-01 -o /Users/jingsi/code/data/gtfs-ws/delfi -i /Users/jingsi/Downloads/google-transit-darwin-200124.zip and it's working.

github-actions[bot] commented 4 months ago

✅ Rule acceptance tests passed. New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1520 sources (~0 %) are corrupted. Commit: 94243f820fa8a8701df02aad732239483f150e2a Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.