search

MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.
https://gtfs-validator.mobilitydata.org/
Apache License 2.0
288 stars 101 forks source link

Inconsistent dependency versions across modules. #1725

Open chaicho opened 8 months ago

chaicho commented 8 months ago

Describe the problem

Currently some modules of gtfs-validator are using the same dependency. However, some of these dependencies' versions are not centrally managed and therefore cause discrepancy. This increases the maintenance workload and may lead to dependency conflict for downstream projects. So it's better to align the versions of the dependencies if the discrepancy is not intentional.

The affected dependencies are listed below.

  1. org.apache.commons:commons-lang3 has version 3.6 in processor but version 3.0 in core and processor/notices
  2. com.google.auto.service:auto-service has version 1.0-rc4 in processor but version 1.0.1 in processor/notices
  3. com.google.flogger:flogger and com.google.flogger:flogger-system-backend has version 0.6.0 in all modules , but version 0.5.1 in output-comparator

Proposed solution

Align the versions of the dependencies to ensure consistency and avoid possible conflicts. And if it's possible, manage the versions of the dependencies centrally.

If you could kindly tell me whether these actions are intentional, I'd be happy to help :).

Alternatives you've considered

No response

Additional context

No response

welcome[bot] commented 8 months ago

Thanks for opening your first issue in this project! If you haven't already, you can join our slack and join the #gtfs-validators channel to meet our awesome community. Come say hi :wave:!

Welcome to the community and thank you for your engagement in open source! :tada:

chaicho commented 7 months ago

@jcpitre Could you help me review this issue? Many thanks :)

jcpitre commented 7 months ago

@jcpitre Could you help me review this issue? Many thanks :)

Hi @chaicho, this issue is assigned to me but unfortunately I will have limited availability for the next 2 weeks. Is this something you consider urgent?

chaicho commented 7 months ago

Hi @chaicho, this issue is assigned to me but unfortunately I will have limited availability for the next 2 weeks. Is this something you consider urgent?

Hi @jcpitre, thanks for getting back to me. While it's not urgent, it would be helpful to have confirmation on the discrepancy so that I can address it accordingly, either by fixing it locally or raising a pull request myself :).

I completely understand the situation, and I don't want to add any unnecessary pressure. If it's too much to handle right now, I'm more than willing to wait until you have more time available :).

davidgamez commented 7 months ago

Hi @chaicho, I took a pick, and as you mentioned, there are a few discrepancies in the dependencies' versions. I don't have the complete picture of why versions defer, but they don't seem to be on purpose. Having centralized versions for the dependencies is very helpful and reduces maintenance issues/conflicts. This is a good time for this change, as we will have enough time to test it before the next GTFS release. If you have time to work on this issue, we will welcome and review your PR. Thanks.