Closed qcdyx closed 3 months ago
✅ Rule acceptance tests passed. New Errors: 0 out of 1522 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 2 out of 1522 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1522 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1522 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1522 sources (~0 %) are corrupted. Commit: 248371417be7869e3fde4df2aa3de6fb4e494128 Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.
Summary: Closes #1756 Closes #1764
Expected behavior:
Only raise a foreign key violation error when network_id is missing from both networks.txt and routes.txt. The validation report should not give a foreign_key_violation error using the test file in #1756 Before the fix: After the fix:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything