MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.
https://gtfs-validator.mobilitydata.org/
Apache License 2.0
288 stars 101 forks source link

Add Flex features to list #1776

Closed emmambd closed 2 months ago

emmambd commented 5 months ago

Describe the problem

Now that Flex is adopted, we want to be able to track usage of Flex features within the validator and within the Mobility Database API, which includes features generated by the GTFS Schedule Validator.

Proposed solution

The following four features should be added:

Booking Rules: At least one record in booking_rules.txt Fixed-Stops Demand Responsive Transit: At least one record in location_groups.txt Zone-based Demand Responsive Transit: At least a trip in stop_times references only location_id Deviated Fixed Route: At least a trip in stop_times references location_id AND stop_id AND arrival_time AND departure_time

Alternatives you've considered

No response

Additional context

No response

emmambd commented 5 months ago

cc @Sergiodero @tzujenchanmbd

tzujenchanmbd commented 5 months ago

I'd like to modify Deviated Fixed Route a bit: At least a trip in stop_times references location_id AND stop_id AND arrival_time AND departure_time

qcdyx commented 5 months ago

@emmambd Could you elaborate on the definition of Zone-based Demand Responsive Transit?

In the first screenshot, each trip_id corresponds to a location_id. Is this a valid example? (I believe yes) What might constitute an invalid example?

image

Is the second screenshot an invalid Zone-based Demand Responsive Transit? (yes, since it contains a_valid_stop_id)

image
emmambd commented 5 months ago

@qcdyx You're correct - Zone-based Demand Responsive Transit should be triggered when there is a location_id associated with a trip_id. It should not be triggered when stop_id is associated with trip_id.

So the logic is: if the trip has a location_id and NO stop_id, trigger Zone-based Demand DRT

make sense?