feat: 1776 add flex features to list

[qcdyx]

Summary:

Closes #1776

Expected behavior: I discovered that the primary reason most of the stop_times.txt files in flex feeds are unparsable is the absence of the required stop_id field. So to test flex features, I commented @Required annotation in the GtfsStopTimesSchema and generated the following report. We need to discuss the logic behind the requirement of the stop_id field for non-flex feeds vs. flex feeds. (I cannot find a flex feed that meets Deviated Fixed Route criteria)

Please make sure these boxes are checked before submitting your pull request - thanks!

• [x] Run the unit tests with gradle test to make sure you didn't break anything
• [ ] Add or update any needed documentation to the repo
• [x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• [x] Linked all relevant issues
• [x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit bcde487147b8819bb55c686de175f4d5a94b182b Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1524 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.97 | 4.12 | ⬆️+0.14 | | Median | -- | 1.35 | 1.45 | ⬆️+0.10 | | Standard Deviation | -- | 11.13 | 11.30 | ⬆️+0.18 | | Minimum in References Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.51 | 0.60 | ⬆️+0.09 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 291.99 | 296.16 | ⬆️+4.17 | | Minimum in Latest Reports | us-michigan-detroit-people-mover-gtfs-417 | 0.52 | 0.54 | ⬆️+0.02 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 291.99 | 296.16 | ⬆️+4.17 |

[emmambd]

I think we have to wait to review/merge this until some other schemas are added and tested, e.g #1750

[emmambd]

stop_id being required changes as part of #1749

[davidgamez]

I think we have to wait to review/merge this until some other schemas are added and tested, e.g #1750

I agree, even if we merge flex features won't be visible until the conditional requirement is added to the schema.

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 15a7c4fba7674fb7e7be3598619c3c67f1226944 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1524 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1524 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.93 | 4.05 | ⬆️+0.13 | | Median | -- | 1.37 | 1.45 | ⬆️+0.08 | | Standard Deviation | -- | 10.75 | 10.93 | ⬆️+0.18 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.49 | 0.58 | ⬆️+0.09 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 279.53 | 286.13 | ⬆️+6.60 | | Minimum in Latest Reports | us-california-city-of-wasco-gtfs-1788 | 0.56 | 0.53 | ⬇️-0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 279.53 | 286.13 | ⬆️+6.60 |