fix: Display empty values for feed_start_date and feed_end_date if there's…

[qcdyx]

Summary: Closes #1790

Expected behavior:

Display empty values for feed_start_date and feed_end_date if there's no data for these two fields.

Please make sure these boxes are checked before submitting your pull request - thanks!

• [ ] Run the unit tests with gradle test to make sure you didn't break anything
• [ ] Add or update any needed documentation to the repo
• [x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• [x] Linked all relevant issues
• [x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit bc4f12886e48a8cb79836cc8cf958d5e4f4c926e Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

13 out of 1576 sources (~1 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 | ✅ | N/A | ❌ | N/A | | mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 | ✅ | N/A | ❌ | N/A | | mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 | ✅ | N/A | ❌ | N/A | | mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 | ✅ | N/A | ❌ | N/A | | pe-aeroexpreso-gtfs-1985 | ✅ | N/A | ❌ | N/A | | tr-kocaeli-kocaeli-gtfs-1122 | ✅ | N/A | ❌ | N/A | | us-arizona-national-park-service-gtfs-1905 | ✅ | N/A | ❌ | N/A | | us-ohio-athens-public-transit-gtfs-4 | ✅ | N/A | ❌ | N/A | | us-wisconsin-beloit-transit-gtfs-392 | ✅ | N/A | ❌ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.79 | 3.89 | ⬆️+0.11 | | Median | -- | 1.35 | 1.43 | ⬆️+0.08 | | Standard Deviation | -- | 10.59 | 10.85 | ⬆️+0.26 | | Minimum in References Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.51 | 0.54 | ⬆️+0.03 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 287.39 | 299.06 | ⬆️+11.66 | | Minimum in Latest Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.51 | 0.54 | ⬆️+0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 287.39 | 299.06 | ⬆️+11.66 |

[emmambd]

@qcdyx Looks good on a QA side! Minor change: can we display "N/A" instead of an empty value? I realized it should match the other null behavior in the summary report (e.g agency email and URL, where if they're empty it returns N/A)

[qcdyx]

@emmambd

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit f9ed1df195403e4a35ab6ef4f0a646129f9d62c4 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

13 out of 1576 sources (~1 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 | ✅ | N/A | ❌ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 | ✅ | N/A | ❌ | N/A | | mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 | ✅ | N/A | ❌ | N/A | | mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 | ✅ | N/A | ❌ | N/A | | mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 | ✅ | N/A | ❌ | N/A | | pe-aeroexpreso-gtfs-1985 | ✅ | N/A | ❌ | N/A | | tr-kocaeli-kocaeli-gtfs-1122 | ✅ | N/A | ❌ | N/A | | us-arizona-national-park-service-gtfs-1905 | ✅ | N/A | ❌ | N/A | | us-ohio-athens-public-transit-gtfs-4 | ✅ | N/A | ❌ | N/A | | us-wisconsin-beloit-transit-gtfs-392 | ✅ | N/A | ❌ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.81 | 3.89 | ⬆️+0.08 | | Median | -- | 1.37 | 1.42 | ⬆️+0.05 | | Standard Deviation | -- | 10.56 | 10.58 | ⬆️+0.02 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.49 | 0.61 | ⬆️+0.12 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 281.63 | 282.04 | ⬆️+0.41 | | Minimum in Latest Reports | ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 | 0.63 | 0.51 | ⬇️-0.12 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 281.63 | 282.04 | ⬆️+0.41 |