feat: 1786 exit gates pathway mode7 must not be bidirectional

qcdyx commented 2 months ago

Summary:

Closes #1786 added new validation rule: bidirectional_exit_gateway

Expected behavior: When a entry in Pathway.txt has pathway mode 7 and is bidirectional, an error bidirectional_exit_gateway is generated.

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[ ] Add or update any needed documentation to the repo
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

github-actions[bot] commented 2 months ago

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

github-actions[bot] commented 2 months ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 9b2eb12812cb0155a938c7da0890a88578f5db94 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (1 out of 1575 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | us-district-of-columbia-washington-wmata-gtfs-1847 | bidirectional_exit_gates |

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.90 | 4.02 | ⬆️+0.12 | | Median | -- | 1.34 | 1.43 | ⬆️+0.08 | | Standard Deviation | -- | 11.41 | 11.40 | ⬇️-0.01 | | Minimum in References Reports | us-florida-citrus-county-transit-gtfs-630 | 0.50 | 0.65 | ⬆️+0.15 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 328.46 | 324.10 | ⬇️-4.36 | | Minimum in Latest Reports | us-california-city-of-wasco-gtfs-1788 | 0.53 | 0.53 | ⬆️+0.00 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 328.46 | 324.10 | ⬇️-4.36 |

emmambd commented 2 months ago

1) As mentioned via Slack, the rule should be bidirectional_exit_gate not bidirectional_exit_gates 2) Will pathways.txt be a part of the References in https://gtfs-validator.mobilitydata.org/rules.html?

qcdyx commented 2 months ago

bidirectional_exit_gate

github-actions[bot] commented 2 months ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 519e19954d961075baed9bd2fae3d54ace5a9546 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (1 out of 1575 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | us-district-of-columbia-washington-wmata-gtfs-1847 | bidirectional_exit_gate |

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.91 | 4.00 | ⬆️+0.09 | | Median | -- | 1.37 | 1.44 | ⬆️+0.07 | | Standard Deviation | -- | 11.32 | 11.38 | ⬆️+0.06 | | Minimum in References Reports | us-oregon-hut-airport-shuttle-gtfs-635 | 0.50 | 0.62 | ⬆️+0.12 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 328.10 | 328.42 | ⬆️+0.33 | | Minimum in Latest Reports | us-oregon-high-desert-point-gtfs-636 | 0.50 | 0.49 | ⬇️-0.01 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 328.10 | 328.42 | ⬆️+0.33 |

qcdyx commented 2 months ago

@emmambd regarding question 2, yes, the new rule should appear in the rules.html. Based on https://github.com/MobilityData/gtfs-validator/pull/1517 and https://github.com/MobilityData/gtfs-validator/pull/1522, as long as comments are written for BidirectionalExitGateNotice class, a description for the new rule (birectional_exit_gate) should be included in the rules.html.

qcdyx commented 2 months ago

emmambd commented 2 months ago

@qcdyx Can you share a screenshot of what the specific notice looks like? I wanted to make sure pathways.txt was linked in the references.

qcdyx commented 2 months ago

Yes @emmambd https://gtfs-validator-staging.mobilitydata.org/rules.html

MobilityData / gtfs-validator