feat: 1534 service window in summary report

[qcdyx]

Summary: Closes #1534

Expected behavior: GTFS Validator report should show Service Date Range under Feed Info section.

1. When only calendar_dates.txt is used test dataset: poa_gtfs.zip )

2. When only calendar_dates.txt is used test dataset: Google_transit.zip

3. When both calendars.txt and calendar_dates.txt are used test dataset: Archive.zip

Please make sure these boxes are checked before submitting your pull request - thanks!

• [x] Run the unit tests with gradle test to make sure you didn't break anything
• [ ] Add or update any needed documentation to the repo
• [x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• [x] Linked all relevant issues
• [x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 039dbfa92e7fc62538aa7c94abaede270ad6a40a Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

7 out of 1575 sources (~0 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A | | us-utah-utah-transit-authority-uta-gtfs-170 | ✅ | N/A | ❌ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.93 | 4.01 | ⬆️+0.08 | | Median | -- | 1.37 | 1.43 | ⬆️+0.06 | | Standard Deviation | -- | 11.66 | 11.89 | ⬆️+0.24 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.51 | 0.61 | ⬆️+0.10 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 349.53 | 358.83 | ⬆️+9.30 | | Minimum in Latest Reports | us-florida-citrus-county-transit-gtfs-630 | 0.53 | 0.56 | ⬆️+0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 349.53 | 358.83 | ⬆️+9.30 |

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit a12fcf6bf61300bb4854de473ae064ff06ac31c9 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

7 out of 1575 sources (~0 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | es-valencia-emt-valencia-gtfs-795 | ✅ | N/A | ❌ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.08 | 4.23 | ⬆️+0.15 | | Median | -- | 1.40 | 1.47 | ⬆️+0.07 | | Standard Deviation | -- | 12.82 | 12.74 | ⬇️-0.08 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.50 | 0.69 | ⬆️+0.19 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 293.01 | 290.27 | ⬇️-2.74 | | Minimum in Latest Reports | ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 | 0.62 | 0.54 | ⬇️-0.07 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 293.01 | 290.27 | ⬇️-2.74 |

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit ce2a0f1b85e678906f7109ddde09319d604b21c9 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

7 out of 1575 sources (~0 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | es-valencia-emt-valencia-gtfs-795 | ✅ | N/A | ❌ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 3.88 | 3.97 | ⬆️+0.09 | | Median | -- | 1.39 | 1.45 | ⬆️+0.06 | | Standard Deviation | -- | 10.59 | 10.67 | ⬆️+0.08 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.50 | 0.52 | ⬆️+0.02 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 288.78 | 288.66 | ⬇️-0.11 | | Minimum in Latest Reports | ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 | 0.53 | 0.52 | ⬇️-0.01 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 288.78 | 288.66 | ⬇️-0.11 |

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit f6faa5e2183db141a54a1c09160137c2e3df36a9 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

7 out of 1575 sources (~0 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | es-valencia-emt-valencia-gtfs-795 | ✅ | N/A | ❌ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.07 | 4.14 | ⬆️+0.08 | | Median | -- | 1.42 | 1.47 | ⬆️+0.06 | | Standard Deviation | -- | 11.57 | 11.83 | ⬆️+0.26 | | Minimum in References Reports | us-california-city-of-wasco-gtfs-1788 | 0.50 | 0.55 | ⬆️+0.05 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.73 | 300.42 | ⬆️+10.69 | | Minimum in Latest Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.58 | 0.53 | ⬇️-0.05 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.73 | 300.42 | ⬆️+10.69 |

[emmambd]

Hey @qcdyx - I'm able to do the spot checks now to see if we need service date ranges in cases where feed_info start date and end date apply!

However, I'm still seeing the bug that was fixed in https://github.com/MobilityData/gtfs-validator/pull/1798. Example report here:

report.json

Since this was merged to master, why would this be happening?

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[qcdyx]

Hey @emmambd it's fixed now.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit bd3a7a171ccfff753a41534f5e9ad004dbcb5f6d Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

20 out of 1588 sources (~1 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | es-valencia-emt-valencia-gtfs-795 | ✅ | N/A | ❌ | N/A | | it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 | ❌ | N/A | ✅ | N/A | | mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 | ❌ | N/A | ✅ | N/A | | mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 | ❌ | N/A | ✅ | N/A | | mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 | ❌ | N/A | ✅ | N/A | | pe-aeroexpreso-gtfs-1985 | ❌ | N/A | ✅ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | tr-kocaeli-kocaeli-gtfs-1122 | ❌ | N/A | ✅ | N/A | | us-arizona-national-park-service-gtfs-1905 | ❌ | N/A | ✅ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A | | us-ohio-athens-public-transit-gtfs-4 | ❌ | N/A | ✅ | N/A | | us-wisconsin-beloit-transit-gtfs-392 | ❌ | N/A | ✅ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.09 | 4.18 | ⬆️+0.10 | | Median | -- | 1.44 | 1.51 | ⬆️+0.07 | | Standard Deviation | -- | 11.75 | 11.82 | ⬆️+0.07 | | Minimum in References Reports | us-michigan-detroit-people-mover-gtfs-417 | 0.52 | 0.73 | ⬆️+0.21 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 301.52 | 302.25 | ⬆️+0.73 | | Minimum in Latest Reports | us-california-city-of-wasco-gtfs-1788 | 0.58 | 0.54 | ⬇️-0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 301.52 | 302.25 | ⬆️+0.73 |

[emmambd]

@qcdyx Sorry Jingsi, one more minor requirements change and then you can merge 🙈 In thinking about how we'll eventually add majority service window to this report, let's change "service dates" to "service window" so we'll have consistency between these concepts.

Once changed, all good and ready to merge :)

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit ce2d11257fdb94e5eda28777c7e7b41aeca6f080 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

20 out of 1588 sources (~1 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | es-valencia-emt-valencia-gtfs-795 | ✅ | N/A | ❌ | N/A | | it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 | ❌ | N/A | ✅ | N/A | | mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 | ❌ | N/A | ✅ | N/A | | mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 | ❌ | N/A | ✅ | N/A | | mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 | ❌ | N/A | ✅ | N/A | | pe-aeroexpreso-gtfs-1985 | ❌ | N/A | ✅ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | tr-kocaeli-kocaeli-gtfs-1122 | ❌ | N/A | ✅ | N/A | | us-arizona-national-park-service-gtfs-1905 | ❌ | N/A | ✅ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A | | us-ohio-athens-public-transit-gtfs-4 | ❌ | N/A | ✅ | N/A | | us-wisconsin-beloit-transit-gtfs-392 | ❌ | N/A | ✅ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.07 | 4.14 | ⬆️+0.07 | | Median | -- | 1.42 | 1.49 | ⬆️+0.06 | | Standard Deviation | -- | 11.64 | 11.68 | ⬆️+0.04 | | Minimum in References Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.50 | 0.67 | ⬆️+0.17 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.11 | 292.00 | ⬇️-4.11 | | Minimum in Latest Reports | us-oregon-hut-airport-shuttle-gtfs-635 | 0.79 | 0.53 | ⬇️-0.26 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.11 | 292.00 | ⬇️-4.11 |

[davidgamez]

@qcdyx The acceptance tests are reporting a few(20) feeds sources corrupted. This means the report was not generated for some reason, and the comparison script cannot compare the previous/latest reports. One of the possible reasons is that the validator throws a critical exception while processing the feed. I tried the ca-ontario-guelph-transit-gtfs-1300 locally with this branch and indeed raised a NullPointerException in line. In this case the service Id was not found in the servicePeriods Map. We can target this specific NullPointerException. In addition, I'm suggesting to wrap with a try/catch the full "discovery" of the service date between line 429 to 507, this will make sure that any exception raised due to a null object is properly caught and the report is generated. I am open to suggestions on how to make sure that the report is generated.

After the changes, let's examine the corrupted files in the acceptance test and ensure that the validator generates the report.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 9942afaee14127bb11f7e6413c1578b09ee3e282 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1568 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

20 out of 1588 sources (~1 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | ca-ontario-guelph-transit-gtfs-1300 | ✅ | N/A | ❌ | N/A | | es-valencia-emt-valencia-gtfs-795 | ✅ | N/A | ❌ | N/A | | it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 | ❌ | N/A | ✅ | N/A | | mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 | ❌ | N/A | ✅ | N/A | | mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 | ❌ | N/A | ✅ | N/A | | mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 | ❌ | N/A | ✅ | N/A | | pe-aeroexpreso-gtfs-1985 | ❌ | N/A | ✅ | N/A | | pl-mazowieckie-komunikacja-miejska-plock-gtfs-1150 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-krosno-gtfs-1002 | ✅ | N/A | ❌ | N/A | | pl-podkarpackie-komunikacja-miejska-przemysl-gtfs-1000 | ✅ | N/A | ❌ | N/A | | th-chiang-mai-northern-chiang-mai-gtfs-1282 | ✅ | N/A | ❌ | N/A | | tr-kocaeli-kocaeli-gtfs-1122 | ❌ | N/A | ✅ | N/A | | us-arizona-national-park-service-gtfs-1905 | ❌ | N/A | ✅ | N/A | | us-michigan-mass-transportation-authority-flint-gtfs-926 | ✅ | N/A | ❌ | N/A | | us-ohio-athens-public-transit-gtfs-4 | ❌ | N/A | ✅ | N/A | | us-wisconsin-beloit-transit-gtfs-392 | ❌ | N/A | ✅ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.08 | 4.20 | ⬆️+0.12 | | Median | -- | 1.41 | 1.50 | ⬆️+0.08 | | Standard Deviation | -- | 11.53 | 11.72 | ⬆️+0.20 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.51 | 0.59 | ⬆️+0.08 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.87 | 291.16 | ⬆️+1.29 | | Minimum in Latest Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.57 | 0.52 | ⬇️-0.05 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.87 | 291.16 | ⬆️+1.29 |

[qcdyx]

@emmambd

[github-actions[bot]]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 6118867f4159177351821d7ad511b318625ae976 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

13 out of 1588 sources (~1 %) are corrupted.

| Dataset | Ref Report Exists | Ref Report Readable | Latest Report Exists | Latest Report Readable | |-----------|-------------------|---------------------|----------------------|------------------------| | it-puglia-mobilita-e-trasporti-molfetta-gtfs-1147 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-moby-gtfs-1048 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-sardinia-ferries-gtfs-1050 | ❌ | N/A | ✅ | N/A | | it-regione-autonoma-della-sardegna-collegamenti-marittimi-tirrenia-gtfs-1051 | ❌ | N/A | ✅ | N/A | | mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 | ❌ | N/A | ✅ | N/A | | mexico-oaxaca-secretaria-de-movilidad-oaxaca-gtfs-2033 | ❌ | N/A | ✅ | N/A | | mx-jalisco-secretaria-de-movilidad-del-estado-de-jalisco-gtfs-1926 | ❌ | N/A | ✅ | N/A | | pe-aeroexpreso-gtfs-1985 | ❌ | N/A | ✅ | N/A | | tr-kocaeli-kocaeli-gtfs-1122 | ❌ | N/A | ✅ | N/A | | us-arizona-national-park-service-gtfs-1905 | ❌ | N/A | ✅ | N/A | | us-ohio-athens-public-transit-gtfs-4 | ❌ | N/A | ✅ | N/A | | us-wisconsin-beloit-transit-gtfs-392 | ❌ | N/A | ✅ | N/A |

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.10 | 4.17 | ⬆️+0.07 | | Median | -- | 1.50 | 1.52 | ⬆️+0.02 | | Standard Deviation | -- | 11.62 | 11.67 | ⬆️+0.05 | | Minimum in References Reports | us-oregon-hut-airport-shuttle-gtfs-635 | 0.50 | 0.55 | ⬆️+0.05 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 293.30 | 293.49 | ⬆️+0.19 | | Minimum in Latest Reports | us-oregon-high-desert-point-gtfs-636 | 0.51 | 0.54 | ⬆️+0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 293.30 | 293.49 | ⬆️+0.19 |

[davidgamez]

This looks good for the scope of the issue. I did create a follow-up issue #1848 to address the pending corrupted feeds.

[cka-y]

Was the service window added to the json report? It's part of the tasking, but couldn't find the information from running the jar from this branch

[qcdyx]

Correct me if I'm wrong but I remembered that we talked about splitting the ticket and focusing on just the service date range on UI when we did the estimate. I recommend merging this PR now, and I’ll create a separate one to add it to the JSON report coz I need to merge master changes into my branch and it takes some time to go thru all the checks. @emmambd @davidgamez

[emmambd]

I'm fine with splitting, but the next priority issue will be adding it to the JSON report in that case, since we can't make any changes to the Mobility Database we want without the JSON report functionality. cc @davidgamez for final call

[qcdyx]

@emmambd could you approve my PR since merging is blocked due to requested changes.

[emmambd]

Did you and @davidgamez discuss? Just waiting for his thoughts on splitting or not before I approve it.

[davidgamez]

Did you and @davidgamez discuss? Just waiting for his thoughts on splitting or not before I approve it.

Yes the JSON changes can be part of a different issue.