feat: update `missing_trip_edge` for flex feed

[cka-y]

Summary:

This update modifies the missing_trip_edge notice to ensure it is not triggered if the GtfsStopTime entity has either the startPickupDropOffWindow or endPickupDropOffWindow column defined.

Expected Behavior:
The missing_trip_edge notice will no longer be triggered in cases where one of the above columns is present. For example, using this dataset, the notice is no longer triggered, as shown below:

Please make sure these boxes are checked before submitting your pull request - thanks!

• [x] Run the unit tests with gradle test to make sure you didn't break anything
• [ ] Add or update any needed documentation to the repo
• [x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• [x] Linked all relevant issues
• [x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

❌ The rule acceptance test has failed for commit 82b99409c78fa8e9e07d124e408c5673913cc5b0 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (19 out of 1575 datasets, ~1%) ❌

Details of new errors due to code change, which is above the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | fi-kainuu-kajaani-gtfs-1136 | missing_required_column | | de-unknown-postauto-ag-gtfs-2053 | missing_trip_edge | | us-chicago-brown-county-heartland-express-gtfs-2037 | missing_trip_edge | | us-chicago-the-otter-express-gtfs-2038 | missing_trip_edge | | us-colorado-all-points-transit-gtfs-2039 | missing_trip_edge | | us-colorado-avon-transit-gtfs-2040 | missing_trip_edge | | us-colorado-baca-area-transportation-gtfs-1087 | missing_trip_edge | | us-colorado-cripple-creek-transportation-gtfs-2042 | missing_trip_edge | | us-colorado-discover-goodwill-gtfs-2043 | missing_trip_edge | | us-colorado-dolores-county-gtfs-1141 | missing_trip_edge | | us-colorado-easy-ride-transportation-gtfs-1195 | missing_trip_edge | | us-colorado-eco-transit-gtfs-2045 | missing_trip_edge | | us-colorado-el-paso-fountain-valley-senior-citizens-program-inc-gtfs-2046 | missing_trip_edge | | us-colorado-envida-gtfs-2044 | missing_trip_edge | | us-colorado-gunnison-valley-rta-gtfs-2048 | missing_trip_edge | | us-colorado-pueblo-transit-gtfs-1232 | missing_trip_edge | | us-colorado-steamboat-springs-transit-gtfs-2051 | missing_trip_edge | | us-colorado-town-of-telluride-gtfs-2050 | missing_trip_edge | | us-colorado-tsc-transit-gtfs-2052 | missing_trip_edge |

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.09 | 4.17 | ⬆️+0.08 | | Median | -- | 1.42 | 1.49 | ⬆️+0.07 | | Standard Deviation | -- | 11.69 | 11.86 | ⬆️+0.17 | | Minimum in References Reports | au-tasmania-merseylink-gtfs-1251 | 0.52 | 0.63 | ⬆️+0.11 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 292.57 | 296.16 | ⬆️+3.59 | | Minimum in Latest Reports | us-california-city-of-wasco-gtfs-1788 | 0.64 | 0.53 | ⬇️-0.11 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 292.57 | 296.16 | ⬆️+3.59 |

[emmambd]

@cka-y Cross referencing with the original PR that added these errors because stop_times.txt was finally parseable for Flex feeds, this acceptance test update looks right! The only one confusing me is missing_required_column for 1136. Any insight into why this PR affects it? Looks like it's already there as a notice on the Mobility Database: https://files.mobilitydatabase.org/mdb-1136/mdb-1136-202406071541/report_5.0.1.html

cc @tzujenchanmbd and @Sergiodero as reference for how we review the acceptance tests :)

[github-actions[bot]]

📝 Acceptance Test Report

📋 Summary

❌ The rule acceptance test has failed for commit 82b99409c78fa8e9e07d124e408c5673913cc5b0 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (18 out of 1575 datasets, ~1%) ❌

Details of new errors due to code change, which is above the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | de-unknown-postauto-ag-gtfs-2053 | missing_trip_edge | | us-chicago-brown-county-heartland-express-gtfs-2037 | missing_trip_edge | | us-chicago-the-otter-express-gtfs-2038 | missing_trip_edge | | us-colorado-all-points-transit-gtfs-2039 | missing_trip_edge | | us-colorado-avon-transit-gtfs-2040 | missing_trip_edge | | us-colorado-baca-area-transportation-gtfs-1087 | missing_trip_edge | | us-colorado-cripple-creek-transportation-gtfs-2042 | missing_trip_edge | | us-colorado-discover-goodwill-gtfs-2043 | missing_trip_edge | | us-colorado-dolores-county-gtfs-1141 | missing_trip_edge | | us-colorado-easy-ride-transportation-gtfs-1195 | missing_trip_edge | | us-colorado-eco-transit-gtfs-2045 | missing_trip_edge | | us-colorado-el-paso-fountain-valley-senior-citizens-program-inc-gtfs-2046 | missing_trip_edge | | us-colorado-envida-gtfs-2044 | missing_trip_edge | | us-colorado-gunnison-valley-rta-gtfs-2048 | missing_trip_edge | | us-colorado-pueblo-transit-gtfs-1232 | missing_trip_edge | | us-colorado-steamboat-springs-transit-gtfs-2051 | missing_trip_edge | | us-colorado-town-of-telluride-gtfs-2050 | missing_trip_edge | | us-colorado-tsc-transit-gtfs-2052 | missing_trip_edge |

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.12 | 4.28 | ⬆️+0.16 | | Median | -- | 1.46 | 1.53 | ⬆️+0.07 | | Standard Deviation | -- | 11.80 | 11.80 | ⬇️-0.00 | | Minimum in References Reports | us-california-catalina-express-gtfs-299 | 0.51 | 0.63 | ⬆️+0.13 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 301.46 | 295.70 | ⬇️-5.76 | | Minimum in Latest Reports | us-oregon-hut-airport-shuttle-gtfs-635 | 0.54 | 0.52 | ⬇️-0.02 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 301.46 | 295.70 | ⬇️-5.76 |

[cka-y]

@emmambd seems like there was a problem with the acceptance tests. Without updating the code, I ran them again and everything seems to work as expected.