feat: changes + added documentation to features

cka-y commented 2 months ago

Summary:

Updated features based on the table description
Added documentation links to the HTML report for each feature

Expected Behavior:

Ensures consistent naming conventions between the HTML report and the official documentation.
Each feature listed in the report now includes a clickable link that directs users to the corresponding section in the official documentation

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[ ] Add or update any needed documentation to the repo
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

github-actions[bot] commented 2 months ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 6258fab4955f6c1d4950030d7d357bccbc5cb0ea Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.06 | 4.11 | ⬆️+0.05 | | Median | -- | 1.41 | 1.46 | ⬆️+0.05 | | Standard Deviation | -- | 11.70 | 11.63 | ⬇️-0.07 | | Minimum in References Reports | us-florida-citrus-county-transit-gtfs-630 | 0.51 | 0.61 | ⬆️+0.10 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 294.52 | 290.99 | ⬇️-3.53 | | Minimum in Latest Reports | us-oregon-high-desert-point-gtfs-636 | 0.52 | 0.53 | ⬆️+0.01 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 294.52 | 290.99 | ⬇️-3.53 |

emmambd commented 2 months ago

@cka-y Looks great! Super minor feedback:

Capitalize "In-Station Traversal Time" Capitalize "Zone-Based Demand Responsive Services" and center text

@tzujenchanmbd @Sergiodero Do you know of specific feeds in the production list that have Predefined Routes with Deviation or Fixed Stops Demand Responsive Service to test with? I'm having some trouble identifying them.

github-actions[bot] commented 2 months ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit f6086bfe588b1ef78c74f46ff884a3d4caf7a3eb Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.05 | 4.09 | ⬆️+0.04 | | Median | -- | 1.42 | 1.46 | ⬆️+0.04 | | Standard Deviation | -- | 11.49 | 11.58 | ⬆️+0.09 | | Minimum in References Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.48 | 0.61 | ⬆️+0.13 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 290.59 | 293.41 | ⬆️+2.83 | | Minimum in Latest Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.58 | 0.53 | ⬇️-0.05 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 290.59 | 293.41 | ⬆️+2.83 |

cka-y commented 2 months ago

✅ done @emmambd

tzujenchanmbd commented 2 months ago

@emmambd Feeds for test: Fixed Stops - https://data.trilliumtransit.com/gtfs/islandtransit-wa-us/islandtransit-wa-us--flex-v2-TEST.zip Predefined Routes with Deviation - https://data.trilliumtransit.com/gtfs/browncounty-mn-us/browncounty-mn-us--flex-v2.zip

emmambd commented 2 months ago

@tzujenchanmbd It looks like the Predefined Routes doesn't trigger for the feed you provided. I think it's because the logic for it from #1776 was:

Deviated Fixed Route: At least a trip in stop_times references location_id AND stop_id AND arrival_time AND departure_time

It looks like it's either location_id or stop_id from the data. Should the rule instead be:

Two trips:

At least one trip in stop_times references location_id AND one trip in stop_times references stop_id, arrival_time and departure_time

github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit a489275882454d1f197927d270b5755d5291bd41 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.07 | 4.20 | ⬆️+0.13 | | Median | -- | 1.42 | 1.50 | ⬆️+0.08 | | Standard Deviation | -- | 11.74 | 11.67 | ⬇️-0.07 | | Minimum in References Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.53 | 0.64 | ⬆️+0.12 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 303.47 | 297.37 | ⬇️-6.10 | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-3-gtfs-1819 | 0.61 | 0.56 | ⬇️-0.06 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 303.47 | 297.37 | ⬇️-6.10 |

tzujenchanmbd commented 1 month ago

@emmambd The rule should still check within 1 trip instead of 2.

It seems the trip t_5374696_b_77497_tn_0 does include these 4 field values, but not in the same entry. Perhaps the current logic is checking the same entry?

emmambd commented 1 month ago

I'll add a new issue for the problem with Predefined Routes.

@cka-y, last comment

Update Frequencies to Frequency-Based Service: https://gtfs.org/getting_started/features/base_add-ons/#frequency-based-service based on discussion with Sergio here https://github.com/MobilityData/gtfs-validator/pull/1812#issuecomment-2374673756

cka-y commented 1 month ago

done here @emmambd

github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 5eed6b3bcd09cf0c83f365f889bec14d73fc2d3b Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.06 | 4.11 | ⬆️+0.06 | | Median | -- | 1.42 | 1.48 | ⬆️+0.06 | | Standard Deviation | -- | 11.51 | 11.59 | ⬆️+0.08 | | Minimum in References Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.51 | 0.51 | ⬇️-0.00 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 293.68 | 298.51 | ⬆️+4.83 | | Minimum in Latest Reports | ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 | 0.51 | 0.51 | ⬇️-0.00 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 293.68 | 298.51 | ⬆️+4.83 |

MobilityData / gtfs-validator