Closed qcdyx closed 1 month ago
Instead of adding a single field, feedServiceNow
add two fields feedServiceNowStartDate
and feedServiceNowEndDate
. Having two fields instead of one will make the service date easier to parse.
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF
.
✅ The rule acceptance has passed for commit b1e4b1ea9760eeb22ce9c21ed90d82ecda3495eb Download the full acceptance test report here (report will disappear after 90 days).
No changes were detected due to the code change.
No changes were detected due to the code change.
No changes were detected due to the code change.
No changes were detected due to the code change.
0 out of 1588 sources (~0 %) are corrupted.
Assess the performance in terms of seconds taken for the validation process.
| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.07 | 4.13 | ⬆️+0.07 | | Median | -- | 1.44 | 1.49 | ⬆️+0.05 | | Standard Deviation | -- | 11.58 | 11.60 | ⬆️+0.02 | | Minimum in References Reports | us-florida-citrus-county-transit-gtfs-630 | 0.50 | 0.55 | ⬆️+0.05 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 299.82 | 297.51 | ⬇️-2.30 | | Minimum in Latest Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.57 | 0.54 | ⬇️-0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 299.82 | 297.51 | ⬇️-2.30 |This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF
.
@davidgamez
✅ The rule acceptance has passed for commit 1e06d1e9d4fa7eb167c625e2034690522427dbc7 Download the full acceptance test report here (report will disappear after 90 days).
No changes were detected due to the code change.
No changes were detected due to the code change.
No changes were detected due to the code change.
No changes were detected due to the code change.
0 out of 1588 sources (~0 %) are corrupted.
Assess the performance in terms of seconds taken for the validation process.
| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.09 | 4.17 | ⬆️+0.08 | | Median | -- | 1.44 | 1.50 | ⬆️+0.06 | | Standard Deviation | -- | 11.64 | 11.65 | ⬆️+0.01 | | Minimum in References Reports | us-california-flex-v2-developer-test-feed-3-gtfs-1819 | 0.50 | 0.55 | ⬆️+0.05 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.86 | 299.66 | ⬆️+2.80 | | Minimum in Latest Reports | us-oregon-high-desert-point-gtfs-636 | 0.56 | 0.54 | ⬇️-0.02 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.86 | 299.66 | ⬆️+2.80 |✅ The rule acceptance has passed for commit 538b150e58c561dbeef854c87ed390e63207c236 Download the full acceptance test report here (report will disappear after 90 days).
No changes were detected due to the code change.
No changes were detected due to the code change.
No changes were detected due to the code change.
No changes were detected due to the code change.
0 out of 1588 sources (~0 %) are corrupted.
Assess the performance in terms of seconds taken for the validation process.
| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.09 | 4.15 | ⬆️+0.06 | | Median | -- | 1.43 | 1.50 | ⬆️+0.07 | | Standard Deviation | -- | 11.72 | 11.48 | ⬇️-0.24 | | Minimum in References Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.51 | 0.54 | ⬆️+0.03 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 301.39 | 288.32 | ⬇️-13.07 | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.51 | 0.54 | ⬆️+0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 301.39 | 288.32 | ⬇️-13.07 |
Summary: Closes #1849 added feedServiceWindow to JSON report
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything