MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.
https://gtfs-validator.mobilitydata.org/
Apache License 2.0
290 stars 101 forks source link

Required and recommended notices on files with no rows #1853

Open davidgamez opened 2 months ago

davidgamez commented 2 months ago

Description

The missing_required_file and missing_recommended_file notices are triggered when the file is not in the feed. This doesn't cover files with headers and no rows. Having a file in the feed with no data(only headers) defeats the intention of the required and recommended notices, as it doesn't encourage producers to add the data.

Solution Proposed

Add additional notices _required_file_empty_ and _recommended_file_empty_ (or a better name) to express that the files are present but have no rows.

Alternative Solution

We can also modify the required and recommended notice to catch files with no rows. The downside is that consumers can be confused when providing a file with no rows and getting missing required or recommended file.

Example fee, https://mobilitydatabase.org/feeds/mdb-1147