MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.
https://gtfs-validator.mobilitydata.org/
Apache License 2.0
288 stars 101 forks source link

feat: added support notice for flex feeds #1861

Closed cka-y closed 1 month ago

cka-y commented 1 month ago

Summary:

This PR introduces an informational notice displayed at the top of the validation report when GTFS Flex feeds are detected.

Expected Behavior:

When a Flex feed is detected, the following informational message is shown:

image

Please make sure these boxes are checked before submitting your pull request - thanks!

emmambd commented 1 month ago

Tested that this displays for any feed with Flex features and -doesn't- display for feeds without Flex. This is great!

A veryyy small nit but remove "the" in the second sentence, so it's: "Please note that GTFS Flex validation support in still in development". Then you're good to go :)

github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 549ae555d7ca9edbcae638c3f47a372db3290475 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.04 | 4.07 | ⬆️+0.04 | | Median | -- | 1.44 | 1.46 | ⬆️+0.02 | | Standard Deviation | -- | 11.53 | 11.48 | ⬇️-0.05 | | Minimum in References Reports | us-california-flex-v2-developer-test-feed-3-gtfs-1819 | 0.51 | 0.52 | ⬆️+0.01 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 298.20 | 292.28 | ⬇️-5.92 | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.52 | 0.52 | ⬇️-0.00 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 298.20 | 292.28 | ⬇️-5.92 |
github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 66a418ec75e7a940e593c4607283f694ef5146cd Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.09 | 4.17 | ⬆️+0.08 | | Median | -- | 1.43 | 1.51 | ⬆️+0.08 | | Standard Deviation | -- | 11.69 | 11.72 | ⬆️+0.03 | | Minimum in References Reports | ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 | 0.51 | 0.53 | ⬆️+0.02 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 298.51 | 301.57 | ⬆️+3.05 | | Minimum in Latest Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 0.65 | 0.52 | ⬇️-0.14 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 298.51 | 301.57 | ⬆️+3.05 |
github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 07a313d20001ed98ae21f745111971f4ff20c0bf Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.04 | 4.14 | ⬆️+0.10 | | Median | -- | 1.44 | 1.54 | ⬆️+0.10 | | Standard Deviation | -- | 11.29 | 11.33 | ⬆️+0.04 | | Minimum in References Reports | us-california-catalina-express-gtfs-299 | 0.50 | 0.67 | ⬆️+0.17 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.24 | 288.84 | ⬇️-0.41 | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.58 | 0.59 | ⬆️+0.01 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.24 | 288.84 | ⬇️-0.41 |
emmambd commented 2 weeks ago

This notice appears for feeds with just the Continuous Stops feature, which isn't a GTFS-Flex service even though it's in the Flexible Services group. We should modify it to display for every feature in the Flexible Services group except Continuous Stops.