MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.
https://gtfs-validator.mobilitydata.org/
Apache License 2.0
288 stars 101 forks source link

fix: `Predefined Routes with Deviation` trigger + test #1862

Closed cka-y closed 1 month ago

cka-y commented 1 month ago

Summary:

This PR fixes the behavior for the Predefined Routes with Deviation feature, ensuring that it is correctly displayed for GTFS Flex feeds, such as this example.

A test case has also been added to validate the fix.

Validation Screenshot

Please make sure these boxes are checked before submitting your pull request - thanks!

emmambd commented 1 month ago

@cka-y Resolved! Thank you

github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 73173a63537e39a5e06e993a5998acdde692bdec Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.07 | 4.13 | ⬆️+0.06 | | Median | -- | 1.43 | 1.47 | ⬆️+0.04 | | Standard Deviation | -- | 11.51 | 11.60 | ⬆️+0.09 | | Minimum in References Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.50 | 0.52 | ⬆️+0.02 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 290.81 | 291.92 | ⬆️+1.12 | | Minimum in Latest Reports | ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 | 0.52 | 0.52 | ⬆️+0.00 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 290.81 | 291.92 | ⬆️+1.12 |
github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 2dfc3b6e5975ca00bc9e1686fa8e4b86e0969f7f Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.08 | 4.12 | ⬆️+0.04 | | Median | -- | 1.43 | 1.49 | ⬆️+0.06 | | Standard Deviation | -- | 11.66 | 11.52 | ⬇️-0.13 | | Minimum in References Reports | us-california-city-of-wasco-gtfs-1788 | 0.51 | 0.55 | ⬆️+0.04 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 304.08 | 293.01 | ⬇️-11.07 | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.58 | 0.54 | ⬇️-0.05 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 304.08 | 293.01 | ⬇️-11.07 |
github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 901cc9f5d17125490540e1b009023838948b66aa Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.02 | 4.08 | ⬆️+0.06 | | Median | -- | 1.42 | 1.48 | ⬆️+0.05 | | Standard Deviation | -- | 11.32 | 11.30 | ⬇️-0.01 | | Minimum in References Reports | us-california-city-of-wasco-gtfs-1788 | 0.52 | 0.53 | ⬆️+0.01 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 290.01 | 290.69 | ⬆️+0.68 | | Minimum in Latest Reports | us-florida-citrus-county-transit-gtfs-630 | 0.65 | 0.53 | ⬇️-0.13 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 290.01 | 290.69 | ⬆️+0.68 |