Closed emmambd closed 1 month ago
For clarification, should we ignore only the rows with location ID and location group ID or any trip with a row with this condition?
For example:
Let's assume that all trip 1 rows violate _decreasing_or_equal_stop_timedistance.
stop_times.txt |
trip_id | stop_id | location_id | location_group_id | ...other fields... |
---|---|---|---|---|---|
1 | stop_x | ... | |||
1 | stop_1 | ... | |||
1 | location_1 | ... |
In this case, should I expect no notice to be triggered or one notice for the second row and the third row to be ignored?
The latter one. We still want to trigger 1 notice for the second row.
I just added code for that as part of https://github.com/MobilityData/gtfs-validator/issues/1885 See PR https://github.com/MobilityData/gtfs-validator/pull/1896
I know now. I did not realize.
Describe the problem
Based on this old feed and its associated validation report,, there are deviated routes for this agency, where drivers can deviate off a fixed route to a specific zone based on demand booking.
In this feed, there are cases where
decreasing_or_equal_stop_time_distance
is triggered on stop times withlocation_id
orlocation_group_id
rather thanstop_id
.This is confusing, because the
stop_id
column will be null in this case.Proposed solution
Create an exception for rows where a
shape_dist_traveled
value is provided and has either an associatedlocation_id
orlocation_group_id
. These rows should be omitted and will be covered in #1885Sample datasets:
https://data.trilliumtransit.com/gtfs/mountadams-wa-us/mountadams-wa-us.zip http://data.trilliumtransit.com/gtfs/thurston-wa-us/thurston-wa-us--flex-v2.zip
Alternatives you've considered
No response
Additional context
No response