MobilityData / gtfs-validator

Canonical GTFS Validator project for schedule (static) files.
https://gtfs-validator.mobilitydata.org/
Apache License 2.0
288 stars 101 forks source link

feat: included network_id as part of the primary key for fare_leg_rules.txt #1894

Closed qcdyx closed 1 month ago

qcdyx commented 1 month ago

Summary: Closes #1889 gtrans-ca-us.zip

Expected behavior: test dataset: Before:

image

After:

image

Please make sure these boxes are checked before submitting your pull request - thanks!

github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit b02c30938576f949230a5e2ee246459a392f8103 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (8 out of 1602 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | us-california-gtrans-gtfs-616 | duplicate_key | | us-california-morro-bay-transit-gtfs-2059 | duplicate_key | | us-california-san-luis-obispo-regional-transit-authority-slorta-gtfs-43 | duplicate_key | | us-california-ventura-county-transportation-commission-gtfs-31 | duplicate_key | | us-california-yubasutter-transit-gtfs-79 | duplicate_key | | us-colorado-el-dorado-transit-gtfs-75 | duplicate_key | | us-massachusetts-massachusetts-bay-transportation-authority-mbta-gtfs-437 | duplicate_key | | us-washington-sound-transit-gtfs-268 | duplicate_key |
New Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1602 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.05 | 4.27 | ⬆️+0.23 | | Median | -- | 1.41 | 1.47 | ⬆️+0.06 | | Standard Deviation | -- | 11.61 | 12.86 | ⬆️+1.25 | | Minimum in References Reports | us-michigan-detroit-people-mover-gtfs-417 | 0.51 | 0.66 | ⬆️+0.16 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.11 | 302.28 | ⬆️+6.17 | | Minimum in Latest Reports | us-oregon-high-desert-point-gtfs-636 | 0.65 | 0.55 | ⬇️-0.09 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.11 | 302.28 | ⬆️+6.17 |
📜 Memory Consumption | Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 489.95 MiB | 491.36 MiB | ⬆️+1.41 MiB | | Median | -- | 246.14 MiB | 245.96 MiB | ⬇️-184.84 KiB | | Standard Deviation | -- | 872.36 MiB | 891.15 MiB | ⬆️+18.79 MiB | | Minimum in References Reports | us-virginia-jaunt-inc-gtfs-1324 | 34.04 MiB | 34.06 MiB | ⬆️+24.00 KiB | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.12 GiB | 9.78 GiB | ⬇️-345.78 MiB | | Minimum in Latest Reports | us-massachusetts-massachusetts-area-express-max-gtfs-431 | 34.06 MiB | 34.05 MiB | ⬇️-8.00 KiB | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.12 GiB | 9.78 GiB | ⬇️-345.78 MiB |
github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit d087d994476dd71f6f0591fae50568f7e053f068 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (8 out of 1602 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | us-california-gtrans-gtfs-616 | duplicate_key | | us-california-morro-bay-transit-gtfs-2059 | duplicate_key | | us-california-san-luis-obispo-regional-transit-authority-slorta-gtfs-43 | duplicate_key | | us-california-ventura-county-transportation-commission-gtfs-31 | duplicate_key | | us-california-yubasutter-transit-gtfs-79 | duplicate_key | | us-colorado-el-dorado-transit-gtfs-75 | duplicate_key | | us-massachusetts-massachusetts-bay-transportation-authority-mbta-gtfs-437 | duplicate_key | | us-washington-sound-transit-gtfs-268 | duplicate_key |
New Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1602 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.04 | 4.10 | ⬆️+0.06 | | Median | -- | 1.41 | 1.45 | ⬆️+0.04 | | Standard Deviation | -- | 11.76 | 11.66 | ⬇️-0.10 | | Minimum in References Reports | us-michigan-detroit-people-mover-gtfs-417 | 0.50 | 0.54 | ⬆️+0.04 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 308.51 | 302.97 | ⬇️-5.54 | | Minimum in Latest Reports | us-michigan-detroit-people-mover-gtfs-417 | 0.50 | 0.54 | ⬆️+0.04 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 308.51 | 302.97 | ⬇️-5.54 |
📜 Memory Consumption | Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 481.40 MiB | 495.13 MiB | ⬆️+13.73 MiB | | Median | -- | 246.05 MiB | 245.89 MiB | ⬇️-163.92 KiB | | Standard Deviation | -- | 841.90 MiB | 876.69 MiB | ⬆️+34.79 MiB | | Minimum in References Reports | us-michigan-detroit-people-mover-gtfs-417 | 34.05 MiB | 34.19 MiB | ⬆️+144.00 KiB | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 9.73 GiB | 9.74 GiB | ⬆️+8.58 MiB | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-1-gtfs-1817 | 34.05 MiB | 34.05 MiB | ⬇️-8.00 KiB | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 9.73 GiB | 9.74 GiB | ⬆️+8.58 MiB |
github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit ffbe83414e1b400d5ecf8cbd1c71694a4a8a2a03 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (8 out of 1602 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | us-california-gtrans-gtfs-616 | duplicate_key | | us-california-morro-bay-transit-gtfs-2059 | duplicate_key | | us-california-san-luis-obispo-regional-transit-authority-slorta-gtfs-43 | duplicate_key | | us-california-ventura-county-transportation-commission-gtfs-31 | duplicate_key | | us-california-yubasutter-transit-gtfs-79 | duplicate_key | | us-colorado-el-dorado-transit-gtfs-75 | duplicate_key | | us-massachusetts-massachusetts-bay-transportation-authority-mbta-gtfs-437 | duplicate_key | | us-washington-sound-transit-gtfs-268 | duplicate_key |
New Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1602 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.01 | 4.09 | ⬆️+0.08 | | Median | -- | 1.38 | 1.47 | ⬆️+0.09 | | Standard Deviation | -- | 11.45 | 11.43 | ⬇️-0.02 | | Minimum in References Reports | us-oregon-hut-airport-shuttle-gtfs-635 | 0.51 | 0.73 | ⬆️+0.21 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 295.81 | 290.63 | ⬇️-5.18 | | Minimum in Latest Reports | ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 | 0.53 | 0.55 | ⬆️+0.02 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 295.81 | 290.63 | ⬇️-5.18 |
📜 Memory Consumption | Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 484.34 MiB | 490.16 MiB | ⬆️+5.81 MiB | | Median | -- | 248.00 MiB | 248.00 MiB | ⬆️+8.00 KiB | | Standard Deviation | -- | 855.67 MiB | 883.30 MiB | ⬆️+27.64 MiB | | Minimum in References Reports | au-queensland-wide-bay-transit-gtfs-651 | 33.69 MiB | 485.94 MiB | ⬆️+452.25 MiB | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 9.79 GiB | 10.01 GiB | ⬆️+222.46 MiB | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 34.05 MiB | 34.05 MiB | ⬇️0 bytes | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 9.79 GiB | 10.01 GiB | ⬆️+222.46 MiB |
emmambd commented 1 month ago

LGTM!

github-actions[bot] commented 1 month ago

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 797ee3d8a06960068174511cd1dd794f1ca66f93 Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (8 out of 1602 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

| Dataset | Notice Code | |---------|-------------| | us-california-gtrans-gtfs-616 | duplicate_key | | us-california-morro-bay-transit-gtfs-2059 | duplicate_key | | us-california-san-luis-obispo-regional-transit-authority-slorta-gtfs-43 | duplicate_key | | us-california-ventura-county-transportation-commission-gtfs-31 | duplicate_key | | us-california-yubasutter-transit-gtfs-79 | duplicate_key | | us-colorado-el-dorado-transit-gtfs-75 | duplicate_key | | us-massachusetts-massachusetts-bay-transportation-authority-mbta-gtfs-437 | duplicate_key | | us-washington-sound-transit-gtfs-268 | duplicate_key |
New Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1602 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1602 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.04 | 4.08 | ⬆️+0.04 | | Median | -- | 1.42 | 1.43 | ⬆️+0.01 | | Standard Deviation | -- | 11.27 | 11.38 | ⬆️+0.11 | | Minimum in References Reports | us-california-city-of-wasco-gtfs-1788 | 0.54 | 0.57 | ⬆️+0.03 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.41 | 295.62 | ⬆️+6.20 | | Minimum in Latest Reports | us-oregon-high-desert-point-gtfs-636 | 0.56 | 0.54 | ⬇️-0.02 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 289.41 | 295.62 | ⬆️+6.20 |
📜 Memory Consumption | Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 475.04 MiB | 477.13 MiB | ⬆️+2.08 MiB | | Median | -- | 244.45 MiB | 244.44 MiB | ⬇️-12.04 KiB | | Standard Deviation | -- | 840.11 MiB | 855.00 MiB | ⬆️+14.89 MiB | | Minimum in References Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 34.48 MiB | 34.48 MiB | ⬆️+4.39 KiB | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.12 GiB | 10.17 GiB | ⬆️+42.69 MiB | | Minimum in Latest Reports | us-california-flex-v2-developer-test-feed-3-gtfs-1819 | 34.50 MiB | 34.48 MiB | ⬇️-16.00 KiB | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.12 GiB | 10.17 GiB | ⬆️+42.69 MiB |