github-actions[bot]
commented
1 month ago 📝 Acceptance Test Report
📋 Summary
✅ The rule acceptance has passed for commit 653e1962bab9c54f29cd1aee0e57ad0a8af6fcc4 Download the full acceptance test report here (report will disappear after 90 days).
📊 Notices Comparison
New Errors (0 out of 1602 datasets, ~0%) ✅
No changes were detected due to the code change.
Dropped Errors (0 out of 1602 datasets, ~0%) ✅
No changes were detected due to the code change.
New Warnings (0 out of 1602 datasets, ~0%) ✅
No changes were detected due to the code change.
Dropped Warnings (0 out of 1602 datasets, ~0%) ✅
No changes were detected due to the code change.
🛡️ Corruption Check
0 out of 1602 sources (~0 %) are corrupted.
⏱️ Performance Assessment
📈 Validation Time
Assess the performance in terms of seconds taken for the validation process.
| Time Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) | |-----------------------------|-------------------|----------------|----------------|----------------| | Average | -- | 4.00 | 4.05 | ⬆️+0.05 | | Median | -- | 1.38 | 1.44 | ⬆️+0.06 | | Standard Deviation | -- | 11.39 | 11.43 | ⬆️+0.04 | | Minimum in References Reports | us-california-flex-v2-developer-test-feed-2-gtfs-1818 | 0.52 | 0.55 | ⬆️+0.03 | | Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.65 | 294.58 | ⬇️-2.06 | | Minimum in Latest Reports | us-california-city-of-wasco-gtfs-1788 | 0.56 | 0.53 | ⬇️-0.03 | | Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 296.65 | 294.58 | ⬇️-2.06 |
Summary: Closes #1885 Added a validator that checks for stopTime entries with location_id or location_group_id values that also have shape_dist_traveled value. If found, add a ForbiddenShapeDistTraveledNotice notice.
Expected behavior:
Used http://data.trilliumtransit.com/gtfs/thurston-wa-us/thurston-wa-us--flex-v2.zip as a test dataset.
Report before the change:
Report after the change:
Essentially we created 156 forbidden_shape_dist_traveled notices. https://github.com/MobilityData/gtfs-validator/pull/1895 should take care of removing the 156 decreasing_or_equal_stop_time_distance notices.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything