MobilityData / mobility-database-catalogs

The Catalogs of Sources of the Mobility Database.
Apache License 2.0
257 stars 51 forks source link

Poland mkuran.pl updates [SOURCES] #493

Closed A-dead-pixel closed 2 weeks ago

A-dead-pixel commented 3 weeks ago

As mostly stated in the commit messages:

feat: add more feeds from mkuran.pl [SOURCES] (the only available one which I haven't added is the Kielce one, as they have a funky license (see mkuran.pl/gtfs).)

fix: update URLs for feeds from mkuran.pl [SOURCES] (/feed/* -> /gtfs/*)

fix: update feeds removed from mkuran.pl [SOURCES]

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

emmambd commented 2 weeks ago

Thanks for this amazing review of available Poland data @A-dead-pixel!

We don't change the URL for feeds, so that there's a consistent definition of what a feed is over time. Because of this, there's two options:

1: You could update this PR to create new feeds for the new URLs, set the status of the old feeds to "deprecated", and add a redirect ID to the new feeds that replace the old ones (everything in fix: update URLs for feeds from mkuran.pl [SOURCES] (/feed/ -> /gtfs/) + the changes to 1014)

2: You could remove the feed updates from this PR, and I could do them instead to make the process simpler for you. This PR would solely consist of the new feeds, and I can add you as a reviewer to the new PR for feed updates.

A-dead-pixel commented 2 weeks ago

Ok, I will update the PR shortly and do the feed updates myself. It does indeed make more sense, especially for 1014.

A-dead-pixel commented 2 weeks ago

I deprecated the feeds and set the redirects to new ones. The only change in the first commit is the message - it had stray .jsons.

A-dead-pixel commented 2 weeks ago

I fixed the conflict between feeds with id 2083 (one in main and the other here) and rebased onto main.