MobilityData / mobility-feed-api

Apache License 2.0
8 stars 3 forks source link

Support multiple languages in the search endpoint #499

Closed emmambd closed 3 months ago

emmambd commented 3 months ago

Describe the problem

Currently in sources.csv, we have multiple languages represented, including English, French, Italian, German, Spanish, Polish, Portuguese. It should be possible to search for words in these languages and return a response, otherwise many international feeds will not be searchable currently.

Proposed solution

Implement changes to the search endpoint and view configuration to support English, French, Italian, German, Spanish, Polish and Portuguese.

Alternatives you've considered

No response

Additional context

No response

davidgamez commented 3 months ago

The search endpoint supports matching full words in any language. The provided example appears in the results. Derived words in languages other than English are not supported. Is the intention of this issue to support different languages matching on lexemes?

emmambd commented 3 months ago

@davidgamez When I tested the endpoint with the query "Société nationale des chemins de fer belges", I got no feeds returned. Full words in any language would cover the scope of this issue.

davidgamez commented 3 months ago

@davidgamez When I tested the endpoint with the query "Société nationale des chemins de fer belges", I got no feeds returned. Full words in any language would cover the scope of this issue.

Let's connect on this. I'm getting the right response from the endpoint.

Screenshot 2024-06-20 at 8 43 01 AM
emmambd commented 3 months ago

@davidgamez Ah, I see my mistake now - I kept the mdb-id in the Swagger test response. Looks good! Then I can close this issue.