MobilityData / mobility-feed-api

Apache License 2.0
9 stars 4 forks source link

feat: metrics using single feature truth #832

Open Alessandro100 opened 6 days ago

Alessandro100 commented 6 days ago

closes #820 Summary:

Updates the feature support to 6.0 for the gtfs metrics. Also consolidates the Features data to a source of truth in the frontend. Added sub group feature to metrics to accommodate Fares V2 and Flex

Expected behavior:

Metrics in the features should have no empty groups and should be displayed correctly

Testing tips:

Go to the GTFS metrics page (Feeds / Features) and play around with to make sure the features are displaying correctly

Please make sure these boxes are checked before submitting your pull request - thanks!

image image Subgroup depicted as Icon + tooltip image

Screenshot with prod analytics image

github-actions[bot] commented 6 days ago

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-832-kjr23xpl.web.app

emmambd commented 5 days ago

@Alessandro100 Can we add Flex as a subgroup? It's all features in Flexible services except Continuous Stops

Also to be clear, we'll use this for internal analytics, but not the public facing search (as discussed in #806 - there's alignment in using tags for extensions like Flex and Fares v2 outside of features)

emmambd commented 5 days ago

@Alessandro100 It looks like the changes to features from FEATURES.md are not reflected here: https://github.com/MobilityData/gtfs-validator/blob/master/docs/FEATURES.md#feature-migration

emmambd commented 5 days ago

@cka-y Any clue about why the counts have changed for the ones where only the name has changed (e.g Bike Allowed, or Text-to-Speech)

image

cka-y commented 5 days ago

@emmambd I'm not sure I fully understand the question, but here's some context that might help:

Does this answer your question? If not, could you clarify or provide more details?

emmambd commented 5 days ago

@cka-y Your second point does - I forgot we've added a fair number of feeds and so it makes sense we're seeing significantly more text-to-speech feeds. Thanks!