Mobiperf / MobiPerf

New MobiPerf Repository
http://mobiperf.com
Other
87 stars 62 forks source link

Notification at the top indicating whether MobiPerf is running in the background #12

Closed quietbamboo closed 12 years ago

quietbamboo commented 12 years ago

Add notification at the top indicating whether MobiPerf is running in the background, i.e., whether periodic setting is enabled or not in the preference page

mdwelsh commented 12 years ago

Can you clarify what you mean by "at the top"? This could mean within the activity window or on the Android status bar. Actually, either is good - I tend to prefer an icon in the status bar, which also helps the app to run more often (since Android gives apps with status bar icons priority); however, a lot of users complained about this when we did it with Speedometer, so I disabled it.

Anyway - I would like to see some kind of app status on the main page of the app including:

huangshu91 commented 12 years ago

Matt, how should the app status be displayed on the main page? I'm confused on what this will look like and how to fit all this information on the main page.

mdwelsh commented 12 years ago

How about this: At the top of the main window (above the 6 buttons) a little text box with enough room for a few lines (say 3 lines) of status text. We can then update that status from anywhere in the app to include things like "Background measurement disabled due to low battery", "Ping measurement running", etc. It just serves as a single place to see what the app's current status is.

quietbamboo commented 12 years ago

Shuheng, can we close this issue now?

mdwelsh commented 12 years ago

This is not done yet. Code: http://speedometer-reviews.appspot.com/6002/

mdwelsh commented 12 years ago

Should make this a default in the beta release.

ghost commented 12 years ago

The code review link is still not LGTM'd. Did it ever get finished? I don't see anything in the code review that stops it being a default now.

huangshu91 commented 12 years ago

No, this was up for review but we decided to roll back before this was ever finished.

// TODO(mdw): Make this a user-selectable option //startSpeedomterInForeGround();

I think running in the background is the default currently but, ideally it is an option and there is an additional notification about which is currently set.

On Tue, Sep 4, 2012 at 4:46 PM, Dominic Hamon notifications@github.comwrote:

The code review link is still not LGTM'd. Did it ever get finished? I don't see anything in the code review that stops it being a default now.

— Reply to this email directly or view it on GitHubhttps://github.com/Mobiperf/MobiPerf/issues/12#issuecomment-8278189.

mdwelsh commented 12 years ago

Please keep the issue open but we need to make this change in the new codebase.

On Tue, Sep 4, 2012 at 2:11 PM, huangshu91 notifications@github.com wrote:

No, this was up for review but we decided to roll back before this was ever finished.

// TODO(mdw): Make this a user-selectable option //startSpeedomterInForeGround();

I think running in the background is the default currently but, ideally it is an option and there is an additional notification about which is currently set.

On Tue, Sep 4, 2012 at 4:46 PM, Dominic Hamon notifications@github.comwrote:

The code review link is still not LGTM'd. Did it ever get finished? I don't see anything in the code review that stops it being a default now.

— Reply to this email directly or view it on GitHub< https://github.com/Mobiperf/MobiPerf/issues/12#issuecomment-8278189>.

— Reply to this email directly or view it on GitHubhttps://github.com/Mobiperf/MobiPerf/issues/12#issuecomment-8279043.

ghost commented 12 years ago

Here's what I'd really like to see, having played with the app a bit:

A small icon in the notification area when Mobiperf is running in the background. When the user expands the notification area, there should be a line item for Mobiperf with a status text. This item should not be 'swipable'.

WDYT?

mdwelsh commented 12 years ago

We had this originally and there is code in Speedometer to do it - I think you have to comment out a couple of lines to turn it on. The problem is that a bunch of users complained about it. So we should decide...

On Fri, Sep 21, 2012 at 7:14 PM, Dominic Hamon notifications@github.comwrote:

Here's what I'd really like to see, having played with the app a bit:

A small icon in the notification area when Mobiperf is running in the background. When the user expands the notification area, there should be a line item for Mobiperf with a status text. This item should not be 'swipable'.

WDYT?

— Reply to this email directly or view it on GitHubhttps://github.com/Mobiperf/MobiPerf/issues/12#issuecomment-8784701.

quietbamboo commented 12 years ago

Can we make the notification "swipable" so as to be more user-friendly? At least, the user will know that MobiPerf is running in the background before they clear the notification field.

ghost commented 12 years ago

What was the nature of the complaint? This is a fairly standard thing that other applications do. Making it swipable would be more confusing, i think, as it might lead the user to think they're closing the process, which they wouldn't be.

mdwelsh commented 12 years ago

A bunch of people complained about it taking up space in the menu bar. It's also not very aesthetic to have yet another icon there. On Sep 24, 2012 8:29 AM, "Dominic Hamon" notifications@github.com wrote:

What was the nature of the complaint? This is a fairly standard thing that other applications do. Making it swipable would be more confusing, i think, as it might lead the user to think they're closing the process, which they wouldn't be.

— Reply to this email directly or view it on GitHubhttps://github.com/Mobiperf/MobiPerf/issues/12#issuecomment-8822785.

ghost commented 12 years ago

I know many apps have background processes that don't show up as icons, but for Mobiperf it feels strange. Possibly because it's such an active process - ie, it's not just waiting for push notifications or polling a server, but is running tests that use CPU/RAM and therefore battery. It's also somewhere to alert the user to the status without cluttering up the main UI.

People will always complain about it taking up space, but not having it is worse, I think.

quietbamboo commented 12 years ago

A compromise might be, if not making things worse, add in the settings an option for users to disable/enable such notifications, and whether to set the default to on or off is to be discussed.

ghost commented 12 years ago

Sounds fair, as long as it doesn't delay launch further. In the interests of launching sooner we could add the icon and then work on a preference to disable it ;)

ghost commented 12 years ago

http://speedometer-reviews.appspot.com/28001/