Closed teamwork523 closed 11 years ago
Code review?
On Thu, Jan 10, 2013 at 5:56 PM, Haokun notifications@github.com wrote:
I include the new TCP Speed Task (measuring TCP Throughput) in the MobiPerf, and it runs against the nearest M-Lab slices. Uplink and downlink task are measuring the network throughput status in both directions. To reduce the memory requirement, we reduce the size of the splashscreen image to limit the occurance of out-of-memory failure.
Detail of the throughput task is shared through Google Docs with title "MobiPerf Throughput Test Summary".
You can merge this Pull Request by running
git pull https://github.com/teamwork523/MobiPerf master
Or view, comment on, or merge it at:
https://github.com/Mobiperf/MobiPerf/pull/147
Commit Summary
Add TCP Throughput Task delete upload.py
File Changes
M .gitignore (6) M README (24) M android/.gitignore (3) M android/AndroidManifest.xml (10) M android/res/drawable/splashscreen.jpg (0) M android/res/layout/about.xml (26) M android/res/layout/console.xml (3) M android/res/layout/measurement_creation_main.xml (56) M android/res/layout/spinner_layout.xml (1) M android/res/values/color.xml (2) M android/res/values/dimen.xml (1) M android/res/values/strings.xml (37) M android/res/xml/preference.xml (4) R android/src/com/mobiperf/About.java (9) R android/src/com/mobiperf/AccountSelector.java (57) R android/src/com/mobiperf/BatteryCapPowerManager.java (5) R android/src/com/mobiperf/Checkin.java (68) R android/src/com/mobiperf/Config.java (5) R android/src/com/mobiperf/DeviceInfo.java (4) R android/src/com/mobiperf/DeviceProperty.java (4) R android/src/com/mobiperf/Logger.java (5) R android/src/com/mobiperf/MeasurementCreationActivity.java (106) R android/src/com/mobiperf/MeasurementDesc.java (5) R android/src/com/mobiperf/MeasurementError.java (4) R android/src/com/mobiperf/MeasurementResult.java (61) R android/src/com/mobiperf/MeasurementScheduleConsoleActivity.java (8) R android/src/com/mobiperf/MeasurementScheduler.java (25) R android/src/com/mobiperf/MeasurementSkippedException.java (4) R android/src/com/mobiperf/MeasurementTask.java (18) R android/src/com/mobiperf/ResultsConsoleActivity.java (12) R android/src/com/mobiperf/SpeedometerApp.java (50) R android/src/com/mobiperf/SpeedometerPreferenceActivity.java (27) R android/src/com/mobiperf/SplashScreenActivity.java (13) R android/src/com/mobiperf/SystemConsoleActivity.java (11) R android/src/com/mobiperf/UpdateIntent.java (6) R android/src/com/mobiperf/WatchdogBootReceiver.java (10) M android/src/com/mobiperf/measurements/DnsLookupTask.java (22) M android/src/com/mobiperf/measurements/HttpTask.java (20) M android/src/com/mobiperf/measurements/PingTask.java (32) A android/src/com/mobiperf/measurements/TCPThroughputTask.java (630) M android/src/com/mobiperf/measurements/TracerouteTask.java (31) M android/src/com/mobiperf/measurements/UDPBurstTask.java (105) A android/src/com/mobiperf/util/MLabNS.java (189) M android/src/com/mobiperf/util/MeasurementJsonConvertor.java (10) M android/src/com/mobiperf/util/PhoneUtils.java (38) M android/src/com/mobiperf/util/Util.java (9) M android/tests/.classpath (3) A android/tests/.gitignore (5) M android/tests/AndroidManifest.xml (6) A android/tests/ant.properties (18) A android/tests/build.xml (92) A android/tests/proguard-project.txt (20) A android/tests/project.properties (14) M android/tests/res/layout/main.xml (2) M android/tests/res/values/strings.xml (3) A android/tests/src/com/mobiperf/speedometer/test/TestCheckin.java (49) A android/tests/src/com/mobiperf/speedometer/test/TestHttpTask.java (65) A android/tests/src/com/mobiperf/speedometer/test/TestMeasurementTaskBase.java (136) A android/tests/src/com/mobiperf/speedometer/test/TestPingTask.java (71) A android/tests/src/com/mobiperf/speedometer/test/TestSchedulerBasic.java (158) A android/tests/src/com/mobiperf/speedometer/test/TestTracerouteTask.java (66) A android/tests/src/com/mobiperf/speedometer/test/UtilTest.java (95) A tcpserver/compile.sh (20) A tcpserver/end.sh (8) A tcpserver/src/servers/Definition.java (14) A tcpserver/src/servers/Downlink.java (23) A tcpserver/src/servers/DownlinkWorker.java (49) A tcpserver/src/servers/ServerConfig.java (22) A tcpserver/src/servers/ServerConfigWorker.java (33) A tcpserver/src/servers/Uplink.java (22) A tcpserver/src/servers/UplinkWorker.java (107) A tcpserver/src/servers/Utilities.java (27) A tcpserver/start.sh (12) A udpburstserver/.gitignore (3) M udpburstserver/Makefile (9) M udpburstserver/udpburstserver.c (5)
Patch Links:
https://github.com/Mobiperf/MobiPerf/pull/147.patch https://github.com/Mobiperf/MobiPerf/pull/147.diff
We finished code reviewing with Dominic this week. I found that I didn't rebase the updated code from mobiperf/master. I generated a new pull request with correct operation.
Great! Thanks.
On Thu, Jan 10, 2013 at 6:59 PM, Haokun notifications@github.com wrote:
We finished code reviewing with Dominic this week. I found that I didn't rebase the updated code from mobiperf/master. I generated a new pull request with correct operation.
— Reply to this email directly or view it on GitHubhttps://github.com/Mobiperf/MobiPerf/pull/147#issuecomment-12130039.
I include the new TCP Speed Task (measuring TCP Throughput) in the MobiPerf, and it runs against the nearest M-Lab slices. Uplink and downlink task are measuring the network throughput status in both directions. To reduce the memory requirement, we reduce the size of the splashscreen image to limit the occurance of out-of-memory failure.
Detail of the throughput task is shared through Google Docs with title "MobiPerf Throughput Test Summary".