mdwelsh
commented
12 years ago Eep, tis big :-) Any chance you could break it into a couple of independent pull reqs to ease review burden? Should be easy if changes to different files can be reviewed independently.... On May 11, 2012 10:37 PM, "drchoffnes" < reply@reply.github.com> wrote:
This changelist includes all the code for validating data, writing results to the datastore and visualizing the results. Test example is here: http://dashboard-test.openmobiledata.appspot.com/validation/dashboard
Note that performance is sub-optimal, but this is not a public dashboard. Sorry for the relatively large pull request, the feature was difficult for me to break into smaller independent pieces.
You can merge this Pull Request by running:
git pull https://github.com/drchoffnes/MobiPerf data_validation
Or you can view, comment on it, or merge it online at:
https://github.com/Mobiperf/MobiPerf/pull/36
-- Commit Summary --
- Changes to support data validation via GAE
- Merge branch 'master' of git://github.com/Mobiperf/MobiPerf into data_validation
- removed unnecessary files, fixed some comments
- merged changes with archive
- adding validation controllers and templates
- removing change to project properity file
- removing empty file
-- File Changes --
M android/project.properties (2) M server/app.yaml.tmpl (4) M server/gspeedometer/controllers/measurement.py (3) A server/gspeedometer/controllers/validation.py (293) A server/gspeedometer/controllers/validation_dashboard.py (145) A server/gspeedometer/controllers/validation_timeseries.py (98) A server/gspeedometer/data/dns.py (75) A server/gspeedometer/data/http.py (103) A server/gspeedometer/data/ipaddr.py (1897) A server/gspeedometer/data/ping.py (98) A server/gspeedometer/data/traceroute.py (98) M server/gspeedometer/main.py (24) M server/gspeedometer/model.py (39) M server/gspeedometer/templates/base.html.tmpl (14) A server/gspeedometer/templates/validation.html (52) A server/gspeedometer/templates/validation_timeseries.html (72) A server/gspeedometer/templates/validationdashboard.html (120) M server/index.yaml (2)
-- Patch Links --
https://github.com/Mobiperf/MobiPerf/pull/36.patch https://github.com/Mobiperf/MobiPerf/pull/36.diff
Reply to this email directly or view it on GitHub: https://github.com/Mobiperf/MobiPerf/pull/36
drchoffnes
This changelist includes all the code for validating data, writing results to the datastore and visualizing the results. Test example is here: http://dashboard-test.openmobiledata.appspot.com/validation/dashboard
Note that performance is sub-optimal, but this is not a public dashboard. Sorry for the relatively large pull request, the feature was difficult for me to break into smaller independent pieces.