search

Mobiperf / MobiPerf

New MobiPerf Repository
http://mobiperf.com
Other
87 stars 62 forks source link

gpsEnabled is set to false by default. #41

Closed haneul closed 12 years ago

haneul commented 12 years ago

It should be true. Also, even after setting through preferences it's reset after rebooting (or process killed and rerun) as the value is not loaded from preferences.

quietbamboo commented 12 years ago

This is already fixed, please close this issue after merging the current pull request

haneul commented 12 years ago

I checked the pull request, but I assume that it requires to change MeasurementScheduler::gpsEnabled value rather than changing only Preference?

huangshu91 commented 12 years ago

You are right. I added a few lines to check for starting value in the next commit.

haneul commented 12 years ago

@huangshu91 Do you mean the commits are also in the pull request?

huangshu91 commented 12 years ago

No, I just mean that I took another look, made some changes, and committed for Junxian to review. I have MeasurementScheduler check the preferences for the default setting upon creation. I think this should be enough to fix the problem.

huangshu91 commented 12 years ago

Should be done.