Mobiperf / MobiPerf

New MobiPerf Repository
http://mobiperf.com
Other
87 stars 62 forks source link

Feature: App needs to display version information #49

Closed mdwelsh closed 12 years ago

mdwelsh commented 12 years ago

version info needs to be on the splash page and on the "About Us" page.

quietbamboo commented 12 years ago

So what's the version number to put into the splash page? v1.0?

quietbamboo commented 12 years ago

I added v 1.0 to about and splash screen. I've submitted a review request.

mdwelsh commented 12 years ago

I didn't see a review request - be sure you mail it to me from the review system.

On Thu, May 31, 2012 at 12:49 PM, Junxian Huang reply@reply.github.com wrote:

I added v 1.0 to about and splash screen. I've submitted a review request.


Reply to this email directly or view it on GitHub: https://github.com/Mobiperf/MobiPerf/issues/49#issuecomment-6045627

quietbamboo commented 12 years ago

I just did. When I submit, upload.py throws some error saying that my image file is too large to be uploaded (about 600KB). But it's fine, I just added a version number to the right bottom of the splash screen image.

quietbamboo commented 12 years ago

Done with pull request https://github.com/Mobiperf/MobiPerf/pull/56