Closed mdwelsh closed 12 years ago
So what's the version number to put into the splash page? v1.0?
I added v 1.0 to about and splash screen. I've submitted a review request.
I didn't see a review request - be sure you mail it to me from the review system.
On Thu, May 31, 2012 at 12:49 PM, Junxian Huang reply@reply.github.com wrote:
I added v 1.0 to about and splash screen. I've submitted a review request.
Reply to this email directly or view it on GitHub: https://github.com/Mobiperf/MobiPerf/issues/49#issuecomment-6045627
I just did. When I submit, upload.py throws some error saying that my image file is too large to be uploaded (about 600KB). But it's fine, I just added a version number to the right bottom of the splash screen image.
Done with pull request https://github.com/Mobiperf/MobiPerf/pull/56
version info needs to be on the splash page and on the "About Us" page.