search

Mobius1 / Selectr

A lightweight, vanilla javascript select box replacement. No dependencies.
MIT License
313 stars 77 forks source link

Update dist min JS to match src JS #131

Open PawelGlow opened 5 years ago

PawelGlow commented 5 years ago

https://github.com/Mobius1/Selectr/blob/master/dist/selectr.min.js does not match https://github.com/Mobius1/Selectr/blob/master/src/selectr.js.

This creates a issue when you include the lib using NPM, it loads the obsolete file from the dist folder which is specified in the package.json "main": "dist/selectr.min.js".

To see the difference search for this phrase this.select(0); and notice the dist min JS file is missing this IF condition: this.config.data.length > 0.

brimimc commented 5 years ago

This is a huge issue for us as the XSS fixes from 8 months ago are not included in the dist/selectr.min.js (works fine using the src selectr.js. How is the min file created and can we get the npm package updated properly??