Address a couple lingering issues higlighted by Lim

MobleyLab / basic_simulation_training

A document for the Living Journal of Computational Molecular Science (LiveCoMS) which describes basic training for molecular simulations (oriented towards molecular dynamics (MD)), providing some training itself and linking out to other helpful information elsewhere. The intent is that this provide information on the prerequisites which will be required for understanding/following many of the other "best practices" documents being prepared.

Creative Commons Attribution 4.0 International

109 stars 19 forks source link

Address a couple lingering issues higlighted by Lim #94

Closed davidlmobley closed 5 years ago

davidlmobley commented 5 years ago

This:

Adds Lim acknowledgment
Clarifies what conditional convergence means
Explain why 1-4 interactions typically reduced

That finalizes the issues Victoria Lim raised.

davidlmobley commented 5 years ago

@hmayes or @JIMonroe can you review?

(And feel free to merge if you like, though at the moment I can't get the PDF to compile for me for some reason. Doesn't seem to have anything to do with these changes, I'm getting an obscure error about ./basic_training.tex:727: pdfTeX error (ext4): \pdfendlink ended up in different nesting level than \pdfstartlink. This happens every time I compile with references so it must have to do with bibliography somehow.)

davidlmobley commented 5 years ago

Apparently the compilation issue was caused by a URL running into a page break so I fixed it by adjusting the wording slightly to push the URL away from the page break.

davidlmobley commented 5 years ago

OK, I just need someone to do a super quick check of this so I can merge. I have some more changes to make (from the peer reviews) and ideally I'd bring them in separately.

I'll start a new branch in the meantime.