MobleyLab / chemper

Repository for Chemical Perception Sampling Tools
MIT License
19 stars 10 forks source link

Update decoration order and environment parsing fixes #65

Closed bannanc closed 5 years ago

bannanc commented 5 years ago

This PR is addressing issue #62 currently, but I'm going to take a look at LGTM and travis to see if I can address issues #61 and #64 also.

I need to see what is causing the tests to fail also.

codecov[bot] commented 5 years ago

Codecov Report

Merging #65 into master will decrease coverage by 0.4%. The diff coverage is 66.08%.

bannanc commented 5 years ago

This pull request fixes 7 alerts when merging a5be002ab30cda7b70c7ff4ac9d6e81c6c62b934 into 3c6510463a2e658ba1a80e3ddb40625b278d404c - view on LGTM.com

fixed alerts:


Comment posted by LGTM.com

bannanc commented 5 years ago

This pull request introduces 5 alerts and fixes 26 when merging f040c2534c548d082ddeeb665286603422c83a64 into 3c6510463a2e658ba1a80e3ddb40625b278d404c - view on LGTM.com

new alerts:

fixed alerts:


Comment posted by LGTM.com

bannanc commented 5 years ago

When trying to fix lgtm I broke a few things and apparently added alerts so there's still a lot of work to do, it is not ready for review.

bannanc commented 5 years ago

This pull request introduces 5 alerts and fixes 26 when merging a1ebce29702e2fe99d1a09768ad05fcde040ae1d into 3c6510463a2e658ba1a80e3ddb40625b278d404c - view on LGTM.com

new alerts:

fixed alerts:


Comment posted by LGTM.com

bannanc commented 5 years ago

This pull request introduces 5 alerts and fixes 26 when merging aa55d6e507684479cca96b1ed51f1482a8e64b82 into 3c6510463a2e658ba1a80e3ddb40625b278d404c - view on LGTM.com

new alerts:

fixed alerts:


Comment posted by LGTM.com

bannanc commented 5 years ago

This pull request introduces 5 alerts and fixes 26 when merging 86a5a0710cfcc7b640a62620145bc057ff1915c6 into 3c6510463a2e658ba1a80e3ddb40625b278d404c - view on LGTM.com

new alerts:

fixed alerts:


Comment posted by LGTM.com

bannanc commented 5 years ago

This pull request introduces 2 alerts and fixes 26 when merging 8d9bce05ea77bbc6f2131c66cb1c266acc40ff73 into 3c6510463a2e658ba1a80e3ddb40625b278d404c - view on LGTM.com

new alerts:

fixed alerts:


Comment posted by LGTM.com

bannanc commented 5 years ago

@jmaat I'm going to merge this one too, I know it would be better for you to review first, but I want to get a version out before I leave this weekend and the order and parsing errors shouldn't be in that. Could you make sure this is on your list to check?