fix several issues and prepare firmware to be fully compatible with wireless module

Mobsya / aseba-target-thymio2

Thymio 2 firmware

8 stars 8 forks source link

fix several issues and prepare firmware to be fully compatible with wireless module #12

Closed mbonani closed 8 years ago

mbonani commented 8 years ago

thank you a lot for your input, I normally implement them all just two points:

the soft.reset function is usefull for some users
write i2c function like the read was tested but i didn't make it works. this functions will not be used a lot of time and could remain a little less the optminal. I am open to your next comment regards

retornaz commented 8 years ago

By reading the bug related to the soft_reset I'm really convinced that the user do not want a soft reset, but a /full/ reset of the VM. So we should do more than the soft_reset() function, but really reset the whole VM (same as the ASEBA_MESSAGE_RESET). So I think we should do this at the aseba level ( @stephanemagnenat a generic native function ? )

mbonani commented 8 years ago

Hi, I rebase with last decisions, one time merge I will make intensive testing and then commit the binaries Warm regards

stephanemagnenat commented 8 years ago

@retornaz a full reset of the VM from a native function needs some care, as the VM will expect some meaningful values for PC and SP when exiting this function, but of course it can be done. I agree with you that a soft_reset is not a good solution. I am just not sure whether now is the good time to implement a full VM reset from a native function.

mbonani commented 8 years ago

I think we can wait for implementing this solution