search

Mobsya / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
1 stars 9 forks source link

added libs+playground #6

Open basilstotz opened 7 years ago

basilstotz commented 7 years ago

Hi,

I added blocks and aesl-generators for the native libs of thymio. Here you find a playground with my addition:

https://amxa.ch/blockly/tests/playground.de.html

Strange: I had to revert commit

https://github.com/basilstotz/blockly/commit/577409ea743e1a0fa51b62ecdd6905425ca75fd1#diff-5c2a14051a1c0d43c8caaf804e33955d

to get the arguments with arrays working!

It not meant, that my commits goes streight to the code: It will need some tidy up before it can be used!

Basil

stephanemagnenat commented 7 years ago

Thank you for your contributions! @mbonani and @cbarraud , could you please test Basil's playground?

I do not understand why math is splitted into I and II, and what is the rationale for deciding which function goes where?

@basilstotz tell me when you think that the library is ready to be merged on your side. Also, I suggest that you announce the ongoing work on the aseba-dev mailing list, as the more people test the better.

mbonani commented 7 years ago

Thank you Basil for the contribution For me it is also strange to have math I and math II,

The generated code seems correct. What it is strange for me is that the blocks are mostly the direct implementation of the generated code. Should it be more phrasing, like

"find the min of array "value" and put result in "value"

to be more consistent with the blockly philosophy?