Moc / wrapper

Wrapper - reincarnation of the 'wrap' plugin
1 stars 5 forks source link

FR - custom title and desc for "error" urls #16

Closed Jimmi08 closed 2 years ago

Jimmi08 commented 2 years ago

Wrong urls are urls without wrapper ID or with wrong ID

Actual state:

Needed:

Moc commented 2 years ago

Debug mode is for debugging (ie. solving bugs), not for general usage.

In what kind of scenarios do you want to display customized titles & messages?

Jimmi08 commented 2 years ago

https://www.e107sk.com/documentation/

it doesn't display title because weird theme behaviour, it is not intention... I will fix it sometimes.

Moc commented 2 years ago

Thanks for the link but can you describe the scenarios in which you would want to display custom titles (other than already defined in the wrapper itself) and custom messages when for example?

Jimmi08 commented 2 years ago

This is for error URLs so no titles from wrapper itself can be used (wrapper is not existing, but url is)

Moc commented 2 years ago

So in case the wrapper ID does not exist (or isn't entered) you want to display no caption? Do I understand that correctly?

Jimmi08 commented 2 years ago

Not fully :) This is wrapper url, everything is ok /documentation/2/e107-developer-guide this work too /documentation/2/ but this was returning ugly error and it is not error in fact, it is plugin frontpage. /documentation/

That error shouldn't be there. It is not error, that page exists just without content. I added content just to use existing link.

Moc commented 2 years ago

I've made some changes:

Now I think I understand your goal: add a custom "homepage" for the wrapper plugin (in your case a landing page for all documentation). I'll think about if I'll add it to the plugin. I'll get back to you on this.