MockbaTheBorg
commented
2 years ago Oh good catch. I will clean it up. Gotta figure out how to use this BFG on Windows though. :)
Thanks, Marcelo
On Thu, Nov 18, 2021 at 8:51 PM cschol @.***> wrote:
I didnt notice this during the integration review for v1, but you have the binary plugin.dll committed to the repository.
This is a problem since it increases the repository size unnecessary when the repo is cloned by the Rack build system.
Can you please remove it from the repository and its history? A new commit is not enough. You can remove it using https://rtyley.github.io/bfg-repo-cleaner/.
Thanks!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MockbaTheBorg/MockbaModular/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD74NCYHGRT7JA7DE4Y5WC3UMWUT3ANCNFSM5ILBLOJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
cschol
I didnt notice this during the integration review for
v1, but you have the binaryplugin.dllcommitted to the repository.This is a problem since it increases the repository size unnecessary when the repo is cloned by the Rack build system.
Can you please remove it from the repository and its history? A new commit is not enough. You can remove it using https://rtyley.github.io/bfg-repo-cleaner/.
Thanks!