Does "res mod" affect the resonance value?

MockbaTheBorg / MockbaModular

Mockba's plugin for VCV Rack

MIT License

15 stars 2 forks source link

Does "res mod" affect the resonance value? #16

Closed jamshark70 closed 6 months ago

jamshark70 commented 6 months ago

https://github.com/MockbaTheBorg/MockbaModular/blob/master/src/Filtah.cpp#L61

I am perhaps missing something, but it looks like MODR_INPUT is retrieved but then not applied to res.

Practical impact is: I connected a MIDI CC (10V) to the resonance mod input and I couldn't hear any difference at any CC value.

MockbaTheBorg commented 6 months ago

It should have worked. Maybe a bad solder joint, or oxidation on the input? 😅 I will check the source code later today and get back to you (traveling at the moment).

MockbaTheBorg commented 6 months ago

With this latest commit I should have fixed the problem. Are you building from source? If so please give it a try.

jamshark70 commented 6 months ago

I haven't been building from source... no worries, just reporting. Thanks!

MockbaTheBorg commented 6 months ago

Okeedokee. I will send the update. 2.0.1 should be out soon.