MockbaTheBorg / RunCPM

RunCPM is a multi-platform, portable, Z80 CP/M 2.2 emulator.
MIT License
411 stars 75 forks source link

[Info] new error-message because of SDFatConfig.h #143

Closed guidol70 closed 2 years ago

guidol70 commented 2 years ago

since the last ESP32-Core (v2.0.2) I had a new error message about the missing change for the SDFatConfig.h (because of a SDFat-Library Update to v2.1.2) from #define SDFAT_FILE_TYPE 3 to #define SDFAT_FILE_TYPE 1

In the past we did get the message 'File' has no member named 'dirEntry'

But now I had the following error/messages:

when compiling RunCPM for ESP32/VGA32

But with the normal change the compile does work again fine :)

MockbaTheBorg commented 2 years ago

Interesting ... so what is the solution exactly? Not to make the change?

guidol70 commented 2 years ago

Interesting ... so what is the solution exactly? Not to make the change? No :) You have to make the change, but it was a new error message and I had to compare my complete Arduino IDE installation - only to find out that it was the missing change after a SDFat-Library update.

So when anyone is getting this "new" error he should think about the "old" change ;)

MockbaTheBorg commented 2 years ago

So the solution is to revert? Back to original pre-change .h file?

MockbaTheBorg commented 2 years ago

Strange that I upgraded my SdFat version to 2.1.2 (from 2.1.0) and I do not have any error? Maybe this is happening to specific boards?
I want to establish what would be the milestone to close this issue.

guidol70 commented 2 years ago

So the solution is to revert? Back to original pre-change .h file?

No - the change is the same as on your READ.ME at github, but I did get the other error because of the missing change. All was fine after applying the change like before when you got a new fresh SDFat-Library.

I dont know from where I did come, because in my portable Installation of the Arduino IDE I didnt get this error-message.

guidol70 commented 2 years ago

Strange that I upgraded my SdFat version to 2.1.2 (from 2.1.0) and I do not have any error? Maybe this is happening to specific boards? I want to establish what would be the milestone to close this issue.

with applied change I didnt got also any problems with SDFat 2.1.2

MockbaTheBorg commented 2 years ago

I think v5.7 already got the change. As I was able to upgrade normally from 2.1.1. I will close for now and then we open one issue in case we find build problems on some platform.