search

ModClean / modclean-patterns-default

Default patterns configuration for ModClean
MIT License
3 stars 2 forks source link

Move *.ts to safe category #6

Closed silverwind closed 5 years ago

silverwind commented 5 years ago

Typescript files are always safe to delete because they will never work in Node.js. This will result in significant size reductions.

Also cleaned up some superfluous whitespace my editor automatically picked up.

Fixes https://github.com/ModClean/modclean-patterns-default/issues/5

smeijer commented 5 years ago

Typescript files are always safe to delete because they will never work in Node.js.

~That's what I thought as well. Unfortunately, removing those did break my build.~

Sorry, I messed up. It were the *.js.map files that I couldn't purge. *.ts can be removed without troubles.

silverwind commented 5 years ago

On second thought, there is some value to keep definitions *.d.ts for editor integrations, so I think it's probably not good to move it to "safe" after all.

smeijer commented 5 years ago

Depends on the usage I think. I see modclean as something to use to build the production bundle. Not to save a few mb on my dev environment.