Remove .bin from pattern

ModClean / modclean

Remove unwanted files and directories from your node_modules folder

MIT License

400 stars 15 forks source link

Remove .bin from pattern #4

Closed git-jiby-me closed 9 years ago

git-jiby-me commented 9 years ago

Please remove .bin from patterns, a lot of projects use the .bin created by npm from local module binaries for different npm scripts, examples being running tests with jasmine, linters like jshint, jscs.

KyleRoss commented 9 years ago

Good catch, that's actually a bug since .bin is repeated in the "danger" patterns. I will remove it from the safe patterns at some point today and will let you know. Thanks for reporting!

git-jiby-me commented 9 years ago

Thanks !

git-jiby-me commented 9 years ago

Any updates on this, it also maybe makes sense to verify all the symlinks in .bin and delete the invalid ones, because if you have done npm dedupe earlier it leaves the invalid symlinks in .bin, which can be safely deleted.

KyleRoss commented 9 years ago

Sorry it took so long (just bought a house and moved). This has been fixed and published to NPM as version 1.2.3.