search

ModClean / modclean

Remove unwanted files and directories from your node_modules folder
MIT License
400 stars 15 forks source link

Fix default `emptyDirFilter` #44

Open s100 opened 2 years ago

s100 commented 2 years ago

It looks as if you copied and pasted the default emptyDirFilter from empty-dir's own documentation, which (at the time) was broken. A completely understandable error. I have opened a PR to fix empty-dir's documentation, but this usage must also be repaired. With its current behaviour, modclean considers nearly every directory to be empty and deletable by default, except those containing only garbage files.

s100 commented 2 years ago

Incidentally, is modclean@3 intended to be ready for production use? If not, I highly recommend you mark modclean@2.1.2 as latest on npm.