search

ModCoderPack / MCPBot-Issues

Issue tracker for MCPBot (https://bitbucket.org/ProfMobius/mcpbot) and MCP mappings.
http://mcpbot.bspk.rs
80 stars 11 forks source link

1.11 Confusing Parameters in func_77659_a #297

Closed TechnicianLP closed 8 years ago

TechnicianLP commented 8 years ago

Item.onItemRightClick(World itemStackIn, EntityPlayer worldIn, EnumHand playerIn) should be changed to Item.onItemRightClick(World world, EntityPlayer player, EnumHand hand)

shadowfacts commented 8 years ago

This is because the 1.11 MCP mappings haven't actually been released yet, so you're using the 1.10.2 mappings applied to 1.11.

tterrag1098 commented 8 years ago

@shadowfacts FG downloads the 1.11 mappings, I don't think this has been fixed yet.

shadowfacts commented 8 years ago

Really? The 1.11 mappings aren't available on export.mcpbot.bspk.rs and when I ran setupDecompWorkspace, it gave me a warning that the mappings being used were designed for 1.10.2, not 1.11

tterrag1098 commented 8 years ago

It downloaded this file for me.

shadowfacts commented 8 years ago

Huh, nevermind then.

matthewprenger commented 8 years ago

shadowfact's original comment is correct. The mcp-1.11-srg.zip file you mentioned is what, among other things, maps notch names(a.ba) to srg names(field_12345_a). Those are up to date for 1.11. The mappings that come out of the bot is what maps srg names(field_12345_a) to mcp names(itemStack). These mappings are still on 1.10.2 which is why you are seeing a mismatch here. Param names are just the method srg number + an index, so when params are added, removed, or re-arranged this will happen.

I'll keep this issue open as a TODO for when the bot gets updated to 1.11.

tterrag1098 commented 8 years ago

Ah whoops, that makes sense. Looking forward to the bot update. On Nov 16, 2016 5:14 PM, "Matthew Prenger" notifications@github.com wrote:

shadowfact's original comment is correct. The mcp-1.11-srg.zip file you mentioned is what, among other things, maps notch names(a.ba) to srg names(field_12345_a). Those are up to date for 1.11. The mappings that come out of the bot is what maps srg names(field_12345_a) to mcp names( itemStack). These mappings are still on 1.10.2 which is why you are seeing a mismatch here. Param names are just the method srg number + an index, so when params are added, removed, or re-arranged this will happen.

I'll keep this issue open as a TODO for when the bot gets updated to 1.11.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ModCoderPack/MCPBot-Issues/issues/297#issuecomment-261089537, or mute the thread https://github.com/notifications/unsubscribe-auth/ADk-8CdHN2Uv_Z_tvS0kwvnw48BPTfgjks5q-4A-gaJpZM4K0fVq .

matthewprenger commented 8 years ago

Fixed.