CustomBossEvent -> CustomBossBar, CustomBossInfo, BossInfoCustom

ModCoderPack / MCPBot-Issues

Issue tracker for MCPBot (https://bitbucket.org/ProfMobius/mcpbot) and MCP mappings.

http://mcpbot.bspk.rs

80 stars 11 forks source link

CustomBossEvent -> CustomBossBar, CustomBossInfo, BossInfoCustom #666

Closed williewillus closed 4 years ago

williewillus commented 6 years ago

The parent class represents a custom boss bar added through the new /bossbar commands, and thus should have similar naming to its parent class.

Also rename CustomBossEvents to be the plural form of whatever we decide here.

kashike commented 6 years ago

The name of these is BossEvent, as shown by the NBT tag CustomBossEvents.

kashike commented 6 years ago

[ ] BossInfo -> BossEvent
[ ] BossInfoClient -> ClientBossEvent
[ ] BossInfoServer -> ServerBossEvent

Runemoro commented 6 years ago

The correct name for CustomBossEvent is CustomBossbar, as shown in BossBarCommand:

    private static int func_201414_a(CommandSource source, CustomBossEvent p_201414_1_) {
        source.sendFeedback(new TextComponentTranslation("commands.bossbar.get.value", p_201414_1_.func_201369_e(), p_201414_1_.getValue()), true);
        return p_201414_1_.getValue();
    }

"commands.bossbar.get.value": "Custom bossbar %s has a value of %s",

kashike commented 4 years ago

Issues regarding class and package names are now handled in the MCPConfig repository.