[1.15.x] Entity.isShiftKeyDown -> Entity.isSneaking

[3TUSK]

• [x] func_225608_bj_ in Entity: isShiftKeyDown -> isSneaking

09:46 <TriTUSK> !gm 225608
09:46 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- === MC 1.15.1: net/minecraft/entity/Entity.isShiftKeyDown (akn.bj) UNLOCKED ===
09:46 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- Name       : bj => func_225608_bj_ => isShiftKeyDown
09:46 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- Descriptor : ()Z
09:46 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- Comment    : None
09:46 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- Last Change: 2020-01-22 04:46:31.041410-05:00 (sp614x)

• As a method that exists on both physical sides, it doesn't make much sense to detect "is Shift key being pressed?" on physical server. Further, it is under Entity, not PlayerEntity. A villager or a skeleton don't and can't press the Shift key on their own.

• (Under 1.15.2) Implementation of func_225608_bj_ calls Entity.getFlag (func_70083_f) with parameter of 1. Comments of func_70083_f:

  Returns true if the flag is active for the entity. Known flags: 0: burning; 1: sneaking; 2: unused; 3: sprinting; 4: swimming; 5: invisible; 6: glowing; 7: elytra flying

  Apparently, it returns if the entity sets the flag for sneaking.

• isSneaking matches up setSneaking (func_226284_e). (Under 1.15.2) func_226284_e calls Entity.setFlag (func_70052_a) with parameter of 1 and boolean isKeyDown.
• There is an old method with (presumably) the same functionality, i.e. isSneaking (func_70093_af, in stable_39).

[3TUSK]

11:32 <TriTUSK> !mh 225608
11:32 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- === Method History: func_225608_bj_ ===
11:32 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- [1.15.1, Staged 2020-04-24 11:18:11.472530-04:00] ichun: isShiftKeyDown => isSneaking
11:32 -MCPBot_Reborn(~MCPBot_Re@mcpbot.bspk.rs)- [1.15.1, Staged 2020-01-22 04:46:31.041410-05:00] sp614x: func_225608_bj_ => isShiftKeyDown