search

ModECI / modelspec

Functionality for specifying models & enabling automatic serialization - will be used by MDF & NeuroMLlite
https://modeci.github.io/modelspec/
Apache License 2.0
3 stars 9 forks source link

Better XML serialization #36

Closed mqnifestkelvin closed 1 year ago

mqnifestkelvin commented 1 year ago

Good morning @pgleeson Apologies for the many branches and pull requests. I've been testing and trying to make the code handling much better in handling serialization especially when converting back to a Python dictionary. I will take down the previous PR and put this one forward to be merged. Thank you and apologies for the delay.

mqnifestkelvin commented 1 year ago

@pgleeson good day, I will check out the codes and see why it's failing the checks. I also merged the PR you made earlier to the branch. I also noticed the new class you created, I will use that to test the xml serialization to see if it represents exactly without change the contents in comparison with the one generated by neuroml

pgleeson commented 1 year ago

Great @mqnifestkelvin. Note, I'd suggest concentrating first on getting the tests passing and getting the current form of the XML exportable/imporrtable, before making changes related to use of attributes in NeuroML.

pgleeson commented 1 year ago

I assume this is out of date now

mqnifestkelvin commented 1 year ago

Hello @pgleeson yes this is out of date, the feature_xml_3 is the most current one for now.