search

ModECI / modelspec

Functionality for specifying models & enabling automatic serialization - will be used by MDF & NeuroMLlite
https://modeci.github.io/modelspec/
Apache License 2.0
3 stars 9 forks source link

Generate and add contributors to documentation #47

Closed Onoyiza closed 1 year ago

Onoyiza commented 1 year ago

Hi @pgleeson. I have added the contributors to modelspec documentation. The changes are:

  1. There are two new files (contributors.py and Contributors.md). The contributors.py file generates "Contributors.md".
  2. A modified "index.rst" to include contributors in the content of the documentation.

I look forward to your feedback. Thank you.

pgleeson commented 1 year ago

Thanks @Onoyiza. Can you add a step in this repo too in the github actions script for generating the documentation, preceeded by running generate.py and contributors.py? Thanks!

pgleeson commented 1 year ago

Also, maybe in a separate branch, can you add tests for windows and mac too, as in the mdf test script?

Onoyiza commented 1 year ago

Thanks @Onoyiza. Can you add a step in this repo too in the github actions script for generating the documentation, preceeded by running generate.py and contributors.py? Thanks!

Yes, I can. Thank you!

Onoyiza commented 1 year ago

Also, maybe in a separate branch, can you add tests for windows and mac too, as in the mdf test script?

Hi @pgleeson.

I have tried to do this but the test fails on one python version for the mac OS but after I ran the failed job twice it worked.

https://github.com/Onoyiza/modelspec/actions

pgleeson commented 1 year ago

Looks good, thanks! Please merge the latest from development into your other branch with win/mac etc. open a pull request and we can discuss issues there.