ModFest / fireblanket

A mod that improves performance, fixes bugs, and adds utilities for Modfest events.
https://example.com/?no modrinth because users are mean :(
Other
10 stars 9 forks source link

Lots of "Received passengers for unknown entity" in the console #11

Closed Virtuoel closed 1 year ago

Virtuoel commented 1 year ago

Received passengers for unknown entity

i think the received passengers thing is fair enough for a fix
can you open an issue

IThundxr commented 1 year ago

this happens in net.minecraft.client.multiplayer.ClientPacketListener public void handleSetEntityPassengersPacket(ClientboundSetPassengersPacket packet )

quat1024 commented 1 year ago

im guessing packets are getting shuffled out of order; a ClientboundAddEntityPacket of the vehicle has to come first so that the numeric ID for that entity gets allocated on the client, only then are other packets allowed to refer to it by that id

to some degree, this type of thing happens in vanilla (you will occasionally get ClientboundRotateHeadPackets or ClientboundSetEntityMotionPackets for entities the server hasn't told you to spawn yet)

IThundxr commented 1 year ago

im guessing packets are getting shuffled out of order; a ClientboundAddEntityPacket of the vehicle has to come first so that the numeric ID for that entity gets allocated on the client, only then are other packets allowed to refer to it by that id

to some degree, this type of thing happens in vanilla (you will occasionally get ClientboundRotateHeadPackets or ClientboundSetEntityMotionPackets for entities the server hasn't told you to spawn yet)

This is just create trains this could be cause of the compression but I swear I've seen this before even without it so just silencing these would probably be the best option