ModFest / glowcase

A mod that adds blocks to help showcase mods and modded items!
https://modrinth.com/mod/glowcase
Creative Commons Zero v1.0 Universal
5 stars 12 forks source link

Networking code is quite messy and insecure #8

Closed quat1024 closed 1 year ago

quat1024 commented 1 year ago

Opening this as a tracking issue (I'm already working on it).

Many of glowcase's packet handlers don't check that the player is in creative mode, has permission to edit the glowcase in question, etc.

Additionally, the packet code is needlessly complex. Sometimes a roundtrip is done to the server for something that can easily be done on the client (like "opening the 'open url confirmation' screen").